<div dir="rtl"><div dir="ltr">Hi,<br><br>Should the [=] capture be replaced here with [&] ?<br>The original reasoning was it's more efficient to capture DeclModule by value rather than by reference.</div><div dir="ltr"><br>Yaron<br><br><br>---------- Forwarded message ----------<br>From: Yaron Keren via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><br>Date: 2015-11-23 21:28 GMT+02:00<br>Subject: r253904 - Replace loop with std::any_of, NFC.<br>To: ‫<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>‬<br><br>Author: yrnkrn<br>Date: Mon Nov 23 13:28:42 2015<br>New Revision: 253904<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253904&view=rev">http://llvm.org/viewvc/llvm-project?rev=253904&view=rev</a><br>Log:<br>Replace loop with std::any_of, NFC.<br>Inspired by similar commits from Craig Topper.<br><br><br>Modified:<br>    cfe/trunk/lib/Sema/SemaLookup.cpp<br><br>Modified: cfe/trunk/lib/Sema/SemaLookup.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaLookup.cpp?rev=253904&r1=253903&r2=253904&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaLookup.cpp?rev=253904&r1=253903&r2=253904&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Sema/SemaLookup.cpp (original)<br>+++ cfe/trunk/lib/Sema/SemaLookup.cpp Mon Nov 23 13:28:42 2015<br>@@ -1535,12 +1535,8 @@ bool LookupResult::isVisibleSlow(Sema &S<br><br>   // Check whether DeclModule is transitively exported to an import of<br>   // the lookup set.<br>-  for (llvm::DenseSet<Module *>::iterator I = LookupModules.begin(),<br>-                                          E = LookupModules.end();<br>-       I != E; ++I)<br>-    if ((*I)->isModuleVisible(DeclModule))<br>-      return true;<br>-  return false;<br>+  return std::any_of(LookupModules.begin(), LookupModules.end(),<br>+                     [=](Module *M) { return M->isModuleVisible(DeclModule); });<br> }<br><br> bool Sema::isVisibleSlow(const NamedDecl *D) {<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br></div></div>