<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hello Serge,<br>
<br>
thank you for your reply.<br>
I'll definitely take a look at your patch. My patch seems to cover
most of your work and even more: it seems to be powerful enough
for implementation of inter-unit analysis for Static Analyzer. If
I'll submit a review, could I add you as a reviewer? I'll split it
into multiple patches since it is more than 3k SLoc.<br>
<br>
<br>
02.11.2015 14:23, Serge Pavlov пишет:<br>
</div>
<blockquote
cite="mid:CACOhrX6HN_H+WmU0W+EC+SPHSPMQgUzP+uqG4wsB5=0vd4ZguQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Hi Alexei,</div>
<div><br>
</div>
<div>ASTImporter seems to be unfinished yet, it even didn't
handled StringLiteral. Nevertheless it is a useful tool and if
handling some nodes is implemented, it works. I put the
implementation of nodes interesting to me into review request
(<a moz-do-not-send="true"
href="http://reviews.llvm.org/D14224">http://reviews.llvm.org/D14224</a>).
Probably we intersect in simple nodes but there are many nodes
unimplemented yet.</div>
<div><br>
</div>
<div>If you are going to develop ASTImporter, it is great, as
import facility is a powerful technique for syntax tools.</div>
<div><br>
</div>
<div>Existing test do not test import facility thoroughly. Some
test may use static_assert, it is convenient for compile only
tests. If the imported handled all nodes, it could be tested
by compiling a source file into ast and then compiling an
empty file with merging the compiled ast file. Now this way to
test is not available though.</div>
<div><br>
</div>
<div class="gmail_extra"><br clear="all">
<div>
<div class="gmail_signature">Thanks,<br>
--Serge<br>
</div>
</div>
<br>
<div class="gmail_quote">2015-10-30 15:58 GMT+06:00 Aleksei
Sidorin via cfe-dev <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a></a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I have some patches for ASTImporter I wish to contribute.
However, I didn't find much tests for it in clang test
suite and I wonder if there is a way to write tests for
ASTImporter? The only tests I found were dedicated to
conflicting declarations.<span class="HOEnZb"><font
color="#888888"><br>
<br>
-- <br>
Best regards,<br>
Aleksei Sidorin<br>
Software Engineer,<br>
IMSWL-IMCG, SRR, Samsung Electronics<br>
<br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards,
Aleksei Sidorin
Software Engineer,
IMSWL-IMCG, SRR, Samsung Electronics
</pre>
</body>
</html>