<div dir="ltr">I copied these file directly from Cling to Tooling/Core/, and renamed them QualTypeNames.[cpp|h].<div><br></div><div>It compiles and works just fine as a direct copy.</div><div><br></div><div>I have made a couple of very minor changes, such as moving the enclosing namespace from cling to clang. Shall I do a more substantial clang-style edit?</div><div><br></div><div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 22, 2015 at 5:29 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Specifially, Benjamin has a patch out that adds a Tooling/Core/Lookup.h where this would fit in quite nicely.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 21, 2015 at 5:31 PM Daniel Berlin <<a href="mailto:dannyb@google.com" target="_blank">dannyb@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The license itself is fine.<div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 21, 2015 at 1:04 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><div dir="ltr">On Wed, Oct 21, 2015 at 8:08 AM Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">ASTContext isn't appropriate for utility code for tooling support; that should go in libTooling instead. The question is whether any of this functionality is useful for the compiler itself or just for tools that use it as a library, and I suspect it's only really useful for the latter.<br></div></blockquote><div><br></div></span><div>Good point, in that case I'd put it somewhere in Tooling/Core. cc'ing Benjamin, who had (planned) a patch to open up a new source file there anyway.</div><div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br></div><div class="gmail_extra">Danny, can you comment on the licensing question?</div></div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 20, 2015 at 9:13 PM, Manuel Klimek via cfe-dev <span dir="ltr"><<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">I think it should probably be part of ASTContext. I have no idea about the license. Richard? </p>
<br><div class="gmail_quote"><div><div><div dir="ltr">On Wed, Oct 21, 2015, 2:27 AM Sterling Augustine via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">So clang folks, where should this new code to calculate the complete, fully qualified name of arbitrary qualtypes go? <div><br></div><div>My best guess is as a new file in clang/lib/AST, but it's not a great fit.</div><div><br></div><div>Does the license as listed in the file (reproduced below) create any issues?</div><div><div><br></div><div>// This file is dual-licensed: you can choose to license it under the University</div><div>// of Illinois Open Source License or the GNU Lesser General Public License. See</div><div>// LICENSE.TXT for details.</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 15, 2015 at 8:47 AM, Philippe Canal <span dir="ltr"><<a href="mailto:pcanal@fnal.gov" target="_blank">pcanal@fnal.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Sterling,<span><br>
<br>
> Would you all be amenable to contributing
cling/lib/Utils/AST.cpp to clang?<br>
<br></span>
Of course :). I agree that this feature belongs in clang proper.<br>
<br>
AST.cpp is pretty much standalone (depends only on clang and llvm)<br>
<br>
Thanks,<br>
Philippe.<br>
<br>
PS. A part that has not yet been integrated in AST.cpp is the
adding of default<br>
template parameters (for user classes where that parameter might
matter for I/O)<br>
and can be found in:<br>
<a href="https://root.cern.ch/gitweb?p=root.git;a=blob;f=core/metautils/src/TMetaUtils.cxx" target="_blank">https://root.cern.ch/gitweb?p=root.git;a=blob;f=core/metautils/src/TMetaUtils.cxx</a><br>
in the routines<br>
ROOT::TMetaUtils::GetNormalizedType<br>
ROOT::TMetaUtils::AddDefaultParameters<br>
ROOT::TMetaUtils::KeepNParams<div><div><br>
<br>
<div>On 10/14/15 11:53 AM, Sterling
Augustine wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Tue, Oct 13, 2015 at 2:48 PM,
Philippe Canal <span dir="ltr"><<a href="mailto:pcanal@fnal.gov" target="_blank"></a><a href="mailto:pcanal@fnal.gov" target="_blank">pcanal@fnal.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi,<br>
<br>
We also discovered that we could not find in clang a
routine that reliably generate the name (or the
equivalent<br>
decl/type) corresponding to a type as it would need to
be typed from the global namespace (i.e. a unique
identifier<br>
of the class); </div>
</blockquote>
<div><br>
</div>
<div>Philippe,</div>
<div><br>
</div>
<div>Would you all be amenable to contributing
cling/lib/Utils/AST.cpp to clang?</div>
<div><br>
</div>
<div>I would be willing to write-up the patch if that would
be helpful. I'm not sure how deep the dependencies go.</div>
</div>
</div>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div></div></div>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div>
<br>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div></div></blockquote></div></div></div></div>
</blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br></div>