<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi, Gabor!<br>
<br>
Yes, I totally missed it. Thanks for pointing it out! I'll fix that
soon. As well as adding the third checker (<i>exceptions.ThrownTypeDiffersSpec</i>)
into the "master" one.<br>
<br>
Many thanks,<br>
Kirill<br>
<br>
<div class="moz-cite-prefix">On 9/6/2015 11:42 PM, Gábor Horváth
wrote:<br>
</div>
<blockquote
cite="mid:CAPRL4a3ctTCComkdtGEJKNGxzrcYzv+8VncRX9qVotb2joXVMw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>Hi!<br>
<br>
</div>
Thank you for working on the static analyzer! I have one
high level comment though. The noexcept or throw() does not
mean that a function can not contain a throw expression. It
means that an exception can not leak out from that function.
So it is perfectly valid to throw an exception and catch it
(without rethrowing it) within a noexcept function. This is
something that you might want to consider (in a future
version).<br>
<br>
</div>
Regards,<br>
</div>
Gabor<br>
<div>
<div>
<div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 6 September 2015 at
22:08, Kirill Bobyrev via cfe-dev <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I've done
the initial version of exceptions checkers
from the <a moz-do-not-send="true"
href="http://clang-analyzer.llvm.org/potential_checkers.html"
target="_blank">potential checkers list</a>.
I actually found <i>exceptions.ThrowSpecButNotThrow</i>
and <i>exceptions.NoThrowSpecButThrows</i>
very similar and decided to put them together
into <i>exceptions.ExceptionSpec</i>. It
checks for "throw calls" in functions
specified as noexcept and functions, which do
not have "throw calls" but should have such
calls inside them by declaration.<br>
<br>
<div bgcolor="#FFFFFF" text="#000000">The
first version of checker is attached. I
wonder if it's good enough and I can push it
for the review.<br>
<br>
Feedback and suggestions highly appreciated!<br>
</div>
<br>
--<br>
Kirill Bobyrev<br>
<a moz-do-not-send="true"
href="https://github.com/omtcyf0"
target="_blank">https://github.com/omtcyf0</a>
</div>
noe<br>
<div>_______________________________________________<br>
cfe-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>