<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;">The link is http://reviews.llvm.org/D11781<br>
I've also added you as reviewer.<br>
Thanks,<br>
Fulvio<br>
<br>
Sent from my Windows Phone</div>
</div>
<div dir="ltr">
<hr>
<span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">From:
</span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:danalbert@google.com">Dan Albert</a></span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Sent:
</span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">06/08/2015 00:16</span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">To:
</span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:fulvio.esposito@live.it">Fulvio Esposito</a></span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Subject:
</span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">Re: [cfe-dev] [libc++] Porting libc++ to Windows</span><br>
<br>
</div>
<div>
<div dir="ltr">
<div>Please add me.</div>
<div><br>
</div>
<div>Should probably just post the link to the review on the thread :)<br>
</div>
</div>
<div class="x_gmail_extra"><br>
<div class="x_gmail_quote">On Wed, Aug 5, 2015 at 2:48 PM, Fulvio Esposito <span dir="ltr">
<<a href="mailto:fulvio.esposito@live.it" target="_blank">fulvio.esposito@live.it</a>></span> wrote:<br>
<blockquote class="x_gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div lang="EN-GB">
<div>
<p>Thank you all. I’ve followed David advice and squashed commits and sent the diff to Phabricator for review. If anyone wants to be added as reviewer, please let me know.</p>
<p>Thanks,</p>
<p>Fulvio</p>
<p><u></u> <u></u></p>
<p><u></u> <u></u></p>
<p><u></u> <u></u></p>
<div style="border:none; border-top:solid #e1e1e1 1.0pt; padding:3.0pt 0cm 0cm 0cm">
<p style="border:none; padding:0cm"><br>
<b>From: </b>Jonathan Roelofs<br>
<b>Sent: </b>05 August 2015 21:40<br>
<b>To: </b>Eric Fiselier;Fulvio Esposito</p>
<div>
<div class="x_h5"><br>
<b>Cc: </b>clang developer list<br>
<b>Subject: </b>Re: [cfe-dev] [libc++] Porting libc++ to Windows</div>
</div>
<p></p>
</div>
<div>
<div class="x_h5">
<p class="x_MsoNormal"><span style="font-family:"Times New Roman",serif"><u></u> <u></u></span></p>
<p class="x_MsoNormal"><span style="font-family:"Times New Roman",serif"><u></u> <u></u></span></p>
<p class="x_MsoNormal"><span style="font-size:12.0pt; font-family:"Times New Roman",serif"><br>
<br>
On 8/5/15 2:29 PM, Eric Fiselier wrote:<br>
> I would prefer phabricator simply because it will get lost on my TODO<br>
> list otherwise. To use phabricator I just run "git diff master" and<br>
> upload that diff to phabricator (assuming your branch in up to date<br>
> with the HEAD of master).<br>
<br>
`git diff master -U999` is preferred to make reviews easier.<br>
<br>
<br>
Jon<br>
<br>
><br>
> /Eric<br>
><br>
> On Wed, Aug 5, 2015 at 3:58 PM, Fulvio Esposito <<a href="mailto:fulvio.esposito@live.it" target="_blank">fulvio.esposito@live.it</a>> wrote:<br>
>> I was using GitHub just because I’ve never used Phabricator. If you can give<br>
>> me some pointers I’ll switch to that. I will also squashing the commits.<br>
>><br>
>> Regards,<br>
>><br>
>> Fulvio<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> From: David Chisnall<br>
>> Sent: 05 August 2015 20:50<br>
>> To: Fulvio Esposito<br>
>> Cc: clang developer list<br>
>> Subject: Re: [cfe-dev] [libc++] Porting libc++ to Windows<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> Hi Fulvio,<br>
>><br>
>> I’m happy to do code review on GitHub if that’s easier for you than<br>
>> Phabricator, but would you mind creating a branch that is rebased on head<br>
>> and has all of the commits squashed, so that I can see a single commit as a<br>
>> diff against head?<br>
>><br>
>> Thanks,<br>
>><br>
>> David<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-dev mailing list<br>
>> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
>><br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
><br>
<br>
-- <br>
Jon Roelofs<br>
<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a><br>
CodeSourcery / Mentor Embedded<u></u><u></u></span></p>
<p class="x_MsoNormal"><u></u> <u></u></p>
<p class="x_MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</body>
</html>