<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang=EN-GB link=blue vlink="#954F72"><div class=WordSection1><p>Thank you all. I’ve followed David advice and squashed commits and sent the diff to Phabricator for review. If anyone wants to be added as reviewer, please let me know.</p><p>Thanks,</p><p>Fulvio</p><p><o:p> </o:p></p><p><o:p> </o:p></p><p><o:p> </o:p></p><div style='mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p style='border:none;padding:0cm'><br><b>From: </b>Jonathan Roelofs<br><b>Sent: </b>05 August 2015 21:40<br><b>To: </b>Eric Fiselier;Fulvio Esposito<br><b>Cc: </b>clang developer list<br><b>Subject: </b>Re: [cfe-dev] [libc++] Porting libc++ to Windows</p></div><p class=MsoNormal><span style='font-family:"Times New Roman",serif'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-family:"Times New Roman",serif'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif'><br><br>On 8/5/15 2:29 PM, Eric Fiselier wrote:<br>> I would prefer phabricator simply because it will get lost on my TODO<br>> list otherwise. To use phabricator I just run "git diff master" and<br>> upload that diff to phabricator (assuming your branch in up to date<br>> with the HEAD of master).<br><br>`git diff master -U999` is preferred to make reviews easier.<br><br><br>Jon<br><br>><br>> /Eric<br>><br>> On Wed, Aug 5, 2015 at 3:58 PM, Fulvio Esposito <fulvio.esposito@live.it> wrote:<br>>> I was using GitHub just because I’ve never used Phabricator. If you can give<br>>> me some pointers I’ll switch to that. I will also squashing the commits.<br>>><br>>> Regards,<br>>><br>>> Fulvio<br>>><br>>><br>>><br>>><br>>><br>>><br>>> From: David Chisnall<br>>> Sent: 05 August 2015 20:50<br>>> To: Fulvio Esposito<br>>> Cc: clang developer list<br>>> Subject: Re: [cfe-dev] [libc++] Porting libc++ to Windows<br>>><br>>><br>>><br>>><br>>><br>>> Hi Fulvio,<br>>><br>>> I’m happy to do code review on GitHub if that’s easier for you than<br>>> Phabricator, but would you mind creating a branch that is rebased on head<br>>> and has all of the commits squashed, so that I can see a single commit as a<br>>> diff against head?<br>>><br>>> Thanks,<br>>><br>>> David<br>>><br>>><br>>><br>>><br>>><br>>> _______________________________________________<br>>> cfe-dev mailing list<br>>> cfe-dev@lists.llvm.org<br>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>>><br>> _______________________________________________<br>> cfe-dev mailing list<br>> cfe-dev@lists.llvm.org<br>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>><br><br>-- <br>Jon Roelofs<br>jonathan@codesourcery.com<br>CodeSourcery / Mentor Embedded<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>