<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 2, 2015 at 7:27 PM Jonathan Roelofs <<a href="mailto:jonathan@codesourcery.com">jonathan@codesourcery.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Even further off topic, in phab wishlist land: It'd be awesome if it<br>
were capable of inferring extended patch context by looking at the svn<br>
repo/git mirrors (rather than requiring the person submitting the patch<br>
to re-upload with -U999).<br></blockquote><div><br></div><div>Yea, this is hard, because detecting which path a patch goes against is hard (for example, if the patch path is a pure add for a new tools/sometool directory, is it in clang or llvm?) and requiring people to do global top-level llvm patches seems rather problematic.</div><div><br></div><div>The workaround is to use arc diff (the command line tool).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Jon<br>
<br>
On 7/2/15 10:52 AM, Keno Fischer wrote:<br>
> This might be slightly off topic, but I'd really like a way to be able<br>
> to run the buildbots off a Phabricator Diff before committing.<br>
><br>
> On Thu, Jul 2, 2015 at 9:01 AM, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a><br>
> <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>>> wrote:<br>
><br>
> Unfortunately threading will be broken for changes currently under<br>
> review (new patches shouldn't have the problem).<br>
> I'm very sorry for this inconvenience :(<br>
><br>
> On Thu, Jul 2, 2015 at 1:47 PM Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a><br>
> <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>>> wrote:<br>
><br>
> Greetings llvm'ers,<br>
><br>
> I'm working on an update to phabricator that brings our fork<br>
> significantly closer to the upstream version, thus making<br>
> maintenance much easier; this will allow us to upgrade more often.<br>
><br>
> Upstream has fixed many issues and introduced new ways to<br>
> customize the email flow, so<br>
><br>
> a) while rolling out the new version I'll be fiddling with<br>
> config settings; during that time, you might see emails that are<br>
> not yet what we'll want the end-state to be; I'll announce on<br>
> this thread once this is done<br>
><br>
> b) the new version gives people more control over the emails;<br>
> that means, if you're a phab user, you might get some emails<br>
> that the list doesn't get (if you wish to); you can configure<br>
> that from phab's email settings<br>
><br>
> Once this is finished, please respond on this thread with your<br>
> concerns / comments, or file bugs at<br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=CnzuN65ENJ1H9py9XLiRvC_UQz6u3oG6GUNn7_wosSM&m=Rtz4bUMrmGvbY8S11jfquK4vIYjgxkhZP2nmHU9iUsU&s=SGfg5IsHtCHtpsGJb2s9i8ErYGJ6LFxxHyoJgUDoRlM&e=" rel="noreferrer" target="_blank">https://llvm.org/bugs/enter_bug.cgi?product=Website</a><br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e=</a>>.<br>
><br>
> Cheers,<br>
> /Manuel<br>
><br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <mailto:<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a>> <a href="http://llvm.cs.uiuc.edu" rel="noreferrer" target="_blank">http://llvm.cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
><br>
<br>
--<br>
Jon Roelofs<br>
<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a><br>
CodeSourcery / Mentor Embedded<br>
</blockquote></div></div>