<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Nikola,<br>
<br>
I've created <a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D9109">http://reviews.llvm.org/D9109</a>, but for unknown reason
as soon as focus lost "reviewer" or "Subscribers" fields it's
content is erased, so I can not add you and cfe list there. Could
you update <a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D9109">http://reviews.llvm.org/D9109</a> appropriately.<br>
<br>
Thank you!<br>
Vladimir.<br>
<br>
<div class="moz-cite-prefix">On 04/18/2015 04:24 AM, Nikola
Smiljanic wrote:<br>
</div>
<blockquote
cite="mid:CAGq7tnOaLttcEAcTeQ8HqZpMuPVjRNS1TbxKvYwDqAOFjFCOVw@mail.gmail.com"
type="cite">
<div dir="ltr">Sorry for not telling you earlier, can you please
upload this to Phabricator and CC me?</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Apr 18, 2015 at 4:43 AM,
Vladimir Voskresensky - Oracle <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:vladimir.voskresensky@oracle.com"
target="_blank">vladimir.voskresensky@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <tt>Hello Nikola,<br>
<br>
Please, review and apply attached patch.<br>
<br>
Thanks!<span class="HOEnZb"><font color="#888888"><br>
Vladimir.<br>
<br>
</font></span></tt>
<div>
<div class="h5">
<div>On 04/14/15 11:14 AM, Nikola Smiljanic wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Looks that way at first glance, feel
free to submit a patch as there seem to be quite a
few places that need updating.</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Apr 4, 2015 at
1:15 AM, Vladimir Voskresensky - Oracle <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:vladimir.voskresensky@oracle.com"
target="_blank">vladimir.voskresensky@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">Hello,<br>
<br>
It looks like the name and documentation of
the first parameter is incorrect<br>
virtual void FileSkipped(const FileEntry
&ParentFile,<br>
const Token
&FilenameTok,<br>
SrcMgr::CharacteristicKind FileType) {<br>
}<br>
<br>
passed ParentFile is in fact SkippedFile.<br>
<br>
The code from
Preprocessor::HandleIncludeDirective which
calls FileSkipped:<br>
<br>
// Ask HeaderInfo if we should enter this
#include file. If not, #including<br>
// this file will have no effect.<br>
if (!HeaderInfo.ShouldEnterIncludeFile(File,
isImport)) {<br>
if (Callbacks)<br>
Callbacks->FileSkipped(*File,
FilenameTok, FileCharacter);<br>
return;<br>
}<br>
<br>
<br>
Thanks,<br>
Vladimir.<br>
<br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-dev@cs.uiuc.edu"
target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>