<div dir="ltr">Hi Alexey,<div><br></div><div>I'd like to be pinged when you start doing that refactoring, just in case I miss it.</div><div><br></div><div>Thanks</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"> Filipe<br></div></div>
<br><div class="gmail_quote">On Tue, Feb 17, 2015 at 4:00 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, Feb 17, 2015 at 3:37 PM, Anna Zaks <span dir="ltr"><<a href="mailto:ganna@apple.com" target="_blank">ganna@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">Unfortunately, we do rely on the Autotools to build for darwin. </div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>The lack of proper testing is very unfortunate. In the future, we will either drop the dependency on Makefile/autoconf build or add the support for sanitizer testing.</div></div></blockquote><div><br></div></span><div>Sorry, for some reason I had the impression that you're also more interested in CMake buiild :-/. Only now I noticed that recent Kuba's patches about -isysroot fix both makefile and CMake</div><div>build system (and he's probably not very happy about it).</div><div><br></div><div>I believe the effort required to port sanitizer unit tests to autotools is not worth it, and it's better to spend that time migrating the release tools to CMake. Keeping two build systems "working"<br></div><div>was and is a manageable, but unpleasant burden. Providing a good test coverage for two runtime versions is hard, and keeping two runtime versions "equivalent" (built with the same compiler flags)</div><div>is close to impossible. </div><div><br></div><div>I understand that removing autotools support right now breaks your integration. What if we just delete autotools support from all Linux builds?</div><div><br></div><div>Speaking of autotools support, I should lay out the reason why I raised the question of removing it last week. We plan to make intrusive changes to ASan and UBSan library layout:</div><div>1) embed UBSan runtime into ASan to solve various initialization and integration problems of using ASan+UBSan (fixing <a href="http://llvm.org/bugs/show_bug.cgi?id=21112" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=21112</a>)</div><div>2) make UBSan runtime standalone, and forbid to use it with another sanitizers except for ASan.</div><div>Unfortunately, it means changing a bunch of build rules in *both* CMake and makefile build.</div><div><br></div><div>Ideally, I would be happy to transfer ownership of current autotools build on Darwin to you, and ask for help in implementing/testing necessary changes on Mac OS X side :)</div><div>At the moment we don't even have a live buildbot running autotools-built ASan on Mac, so you're in much better shape to catch and notice regressions.</div><span class=""><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><span><font color="#888888"><div><br></div></font></span><div><span><font color="#888888">Anna.<br></font></span><div><div><br><div><blockquote type="cite"><div><div><div>On Feb 17, 2015, at 10:54 AM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br></div></div><div><div><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">+1 (in case you still need mine)</div><div class="gmail_extra" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br><div class="gmail_quote">On Thu, Feb 12, 2015 at 6:31 PM, Alexey Samsonov<span> </span><span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi everyone,<div><br></div><div>TL;DR I plan to do subj unless anyone objects.</div><div><br></div><div>Autotools support for building sanitizers was never complete, is a proper subset of CMake capabilities, and the gap between the features of CMake build and autotools is quickly increasing:</div><div>1) OS: autotools support Linux, Mac OS X and Android; CMake also supports FreeBSD and Windows.</div><div>2) Architectures: autotools support i386 and x86_64, CMake also supports MIPS, ARM/AArch64, PowerPC).</div><div>3) Library variants: autotools don't support building shared ASan runtime on Linux.</div><div>4 [!!!]) Autotools build doesn't have *any* support for building and running tests.</div><div>5) The sets of compiler flags we use to build runtimes are different in two builds, and are hard to kept in sync.</div><div><br></div><div>Because of (4), sanitizer runtimes built with autotools are severely undertested, and maintaining two different build systems is a burden I would like to get rid of. Now seems to be a good time for that: we've cut off 3.6 release branch, and Hans assures me that 3.7 release process will use CMake.</div><div><br></div><div>Are there existing users of configure/make that want sanitizers to be available in their build? Are there other arguments for keeping the autotools build "working" I'm missing?</div><span><font color="#888888"><div><br></div><div>--<span> </span><br><div><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div></div></font></span></div></blockquote></div><br></div></div></div><span><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">LLVM Developers mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:LLVMdev@cs.uiuc.edu" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">LLVMdev@cs.uiuc.edu</a><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important"><span> </span> </span><a href="http://llvm.cs.uiuc.edu/" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://llvm.cs.uiuc.edu</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a></span></div></blockquote></div><br></div></div></div></div></div></blockquote></span></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</font></span></div></div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><br></div></div>