<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div>Hi Richard,<br></div>
<div> </div>
<div>It turns out it'd be useful to rebuild the "diagtool" binary so that it can pick up the changes... :)<br></div>
<div>Sorry about the noise and thank you for your help!<br></div>
<div> </div>
<div id="sig19426269"><div class="signature">---<br></div>
<div class="signature">Best regards,<br></div>
<div class="signature"> </div>
<div class="signature">Gábor 'ShdNx' Kozár<br></div>
<div class="signature"><a href="http://gaborkozar.me">http://gaborkozar.me</a><br></div>
<div class="signature"> </div>
</div>
<div> </div>
<div> </div>
<div>On Thu, Jan 8, 2015, at 18:31, Richard Trieu wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>Hi Gabor,<br></div>
<div> </div>
<div>You method looks correct for adding a new warning with a warning flag. It doesn't look like it would affect the warning flags test. Could you attach a diff so I can take a closer look?<br></div>
<div> </div>
<div><div>Richard<br></div>
<div><div> </div>
<div defang_data-gmailquote="yes"><div>On Thu, Jan 8, 2015 at 8:38 AM, Gabor Kozar <span dir="ltr"><<a defang_rel="noreferrer" href="mailto:kozargabor@gmail.com" target="_blank">kozargabor@gmail.com</a>></span> wrote:<br></div>
<blockquote defang_data-gmailquote="yes" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><u></u><br></div>
<div><div>Hi,<br></div>
<div> </div>
<div>So I've implemented a new warning in clang, but now the test Misc/warning-flags.c is failing: I need to introduce a flag corresponding to this warning.<br></div>
<div> </div>
<div>This is about how my warning looks like in DiagnosticSemaKinds.td:<br></div>
<div> </div>
<blockquote><div>def warn_my_first_warning: Warning<<br></div>
<div> "something is wrong here">,<br></div>
<div> InGroup<MyFirstWarning>;<br></div>
</blockquote><div> </div>
<div>And I've created a corresponding group in DiagnosticGroups.td:<br></div>
<div> </div>
<blockquote><div>def MyFirstWarning: DiagGroup<"my-first-warning">;<br></div>
<div> </div>
<div>def MyWarnings : DiagGroup<"my", [MyFirstWarning]>;<br></div>
</blockquote><div> </div>
<div>But this does not seem to have fixed the issue, I still see my warning in the output of diagtool in the "Warnings without flags" list.<br></div>
<div> </div>
<div>I couldn't find any relating information in the clang documentation. Any help would be appreciated.<br></div>
<div> </div>
<div><div>---<br></div>
<div>Best regards,<br></div>
<div> </div>
<div>Gábor 'ShdNx' Kozár<br></div>
<div><a defang_rel="noreferrer" href="http://gaborkozar.me" target="_blank">http://gaborkozar.me</a><br></div>
<div> </div>
</div>
<div> </div>
</div>
<div> </div>
<div>_______________________________________________<br></div>
<div>
cfe-dev mailing list<br></div>
<div> <a defang_rel="noreferrer" href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br></div>
<div> <a defang_rel="noreferrer" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br></div>
<div> </div>
</blockquote></div>
<div> </div>
</div>
</div>
</div>
</blockquote><div> </div>
</body>
</html>