<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Dec 18, 2014 at 10:25 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yep, the general idea is:<br>1. if it's using ASTMatchers or PPCallbacks, make it a clang-tidy check<div>2. if it's using the CFG / being path sensitive, make it a Static Analyzer checker</div><div><br></div><div>Note that static analyzer checkers are integrated in clang-tidy automatically - usually style rule stuff is much easier expressed in clang-tidy though (and I don't think static analyzer checks are integrated well with fix-its (but I'm not sure), and style violations usually have easy fix-its).</div></blockquote><div><br></div><div>+1</div><div>If your checks don't yet suggest fixes, I'd urge you to implement fixes at least for all checks, where it's straightforward. Style warnings are close to useless without fix-its, because not many people like spending time to fix manually style nits in their code.</div><div><br></div><div>If you have any questions re: porting the checks to clang-tidy, I'll be happy to help.</div><div><br></div><div>-- Alex</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><div class="gmail_quote">On Thu Dec 18 2014 at 1:40:05 AM Sean Silva <<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+Manuel<div><br></div><div>clang-tidy seems like a natural place for things that find "<span style="font-family:arial,helvetica,sans-serif;font-size:13px;line-height:14.720000267028809px">design rule violations".</span></div></div><div dir="ltr"><div><span style="font-family:arial,helvetica,sans-serif;font-size:13px;line-height:14.720000267028809px"><br></span></div><div><span style="font-family:arial,helvetica,sans-serif;font-size:13px;line-height:14.720000267028809px">-- Sean Silva</span></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Wed, Dec 17, 2014 at 4:50 AM, Gábor Horváth <span dir="ltr"><<a href="mailto:xazax.hun@gmail.com" target="_blank">xazax.hun@gmail.com</a>></span> wrote:</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">
<p class="MsoNormal" style="margin-bottom:12pt;line-height:normal"><span style="font-family:arial,helvetica,sans-serif"><font>Hello everyone,</font></span></p><span style="font-family:arial,helvetica,sans-serif"><font>
</font></span><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font><span style="line-height:115%">I am an
intern at a company where we developed several checkers based on the clang
infrastructure. We have about 30 checkers that are either C++ core language or
STL related. We would like to contribute some of these checkers (together with
the documentation and the test cases). The ones that are well tested and have
good false positive rates.</span></font></span></p><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font><span style="line-height:115%"><br></span></font></span></p><span style="font-family:arial,helvetica,sans-serif"><font>
</font></span><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font><span style="line-height:115%">Most of
the checkers were originally developed find certain design rule violations. One
example of a design rule at this company is: „The emptiness of a container
should be checked using the empty method instead of the size method. It is not
guaranteed that size is a constant-time function, and it is generally more
efficient and also shows clearer intent to use empty. Furthermore some
containers may implement the empty method but not implement the size method.
Using empty whenever possible makes it easier to switch to another container in
the future.” We realized that, maybe such checkers could be useful for the
clang community as well.</span></font></span></p><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font><span style="line-height:115%"><br></span></font></span></p><span style="font-family:arial,helvetica,sans-serif"><font>
</font></span><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font><span style="line-height:115%">Our tool
right now is a clang plugin that runs custom frontend actions on the analyzed
source code. The reason is that, some of the checkers are only consist of
ASTMatchers, some of them using RecursiveASTVisitors, some of them are clang
Static Analyzer checkers. We are wondering what would be the desired way to
contribute those checkers back. Should we focus on migrating them to
clang-tidy? Should we focus on transforming them to Static Analyzer checkers?</span></font></span></p><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font><span style="line-height:115%"><br></span></font></span></p><span style="font-family:arial,helvetica,sans-serif"><font>
</font></span><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font>Thanks,</font></span></p><span style="font-family:arial,helvetica,sans-serif"><font>
</font></span><p class="MsoNormal"><span style="font-family:arial,helvetica,sans-serif"><font>Gábor Horváth</font></span></p>
</div>
<br></div></div>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br><br></blockquote></div></div></blockquote></div></blockquote></div>
</div></div>