<div dir="ltr"><div><div><div>Thank you very much for your input.<br></div><br>I've done some research and found <a href="http://pocoproject.org" target="_blank">http://pocoproject.org</a> (<a href="https://github.com/pocoproject/poco" target="_blank">https://github.com/pocoproject/poco</a> <a href="http://www.appinf.com/download/CppCodingStyleGuide.pdf" target="_blank">http://www.appinf.com/download/CppCodingStyleGuide.pdf</a> page 27/52) uses it.<br></div><div></div><div><br></div>For full disclosure, I'm hoping to adopt clang-format for the projects we develop at work.<br>The style we use has no indentation for the initializers, this is an option that already exist in clang-format, and address the style concern you had.<br></div><div>After the patch the following style will be allowed:<br></div><div><div><br><div>Constructor( // Arguments too long to fit on the same line</div><div> SomeArgument some_argument,</div><div> SomeOtherArgument some_other_argument) :<br></div><div>some_argument_(some_argument),</div><div>some_other_argument_(some_other_argument)<br>{</div><div>}</div><br></div><div>I'm new to the process and the tools. I've submitted a very small patch before, hopefully will be relatively uncontroversial. It updates the test and should ease the process and clarify the patch for the feature:<a href="http://reviews.llvm.org/D5346" target="_blank"> http://reviews.llvm.org/D5346</a><br></div><div>For the feature itself, I'll submit one patch after the process for this review is completed.<br></div><div><br></div><div>Cheers,<br></div><div>Jean-Philippe.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2014-09-14 10:34 GMT+01:00 Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Not entirely sure what advise you are looking for.<div>My thoughts:<div>- I am happy to accept a patch provided is has sufficient unit tests</div><div>- I think this should go in as a single patch, I don't see a need for "a set of small patches"</div><div>- Personally, I think this style is bad as it makes it harder to distinguish wrapped constructor arguments from initializers</div><div>- In particular, how do you indent:</div><div><br></div><div>Constructor( // Arguments too long to fit on the same line</div><div> SomeArgument some_argument,</div><div> SomeOtherArgument some_other_argument) :</div><div> some_argument_(some_argument),</div><div> some_other_argument_(some_other_argument) {</div><div>}</div><div><br></div><div>Is this style used in any large project or widely used style guide?</div><div><br></div><div>Cheers,<br>Daniel</div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Sun, Sep 14, 2014 at 10:34 AM, Jean-philippe Dufraigne <span dir="ltr"><<a href="mailto:j.dufraigne@gmail.com" target="_blank">j.dufraigne@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div>Hello,<br><br></div><div>I'm interested in adding support for another style for constructor colon and initializer.<br>An example of the style is above the value BCIS_AfterColonAndComma bellow.<br></div><div><br>BreakConstructorInitializers would replace 'bool BreakConstructorInitializersBeforeComma;' while maintaining backward compatibility, in a similar fashion it was done before.<br><br></div><div>I have the prototype for the code and would be really happy to finalize it and contribute a set of small patches.<br><br></div><div>Please let me know if this something that fits with the project and if you have any advice.<br></div><div>Best Regards,<br></div><div>Jean-Philippe<br></div><div><br> /// \brief Different ways to break initializers.<br> enum BreakConstructorInitializersStyle<br> {<br> /// Constructor()<br> /// : initializer1(),<br> /// initializer2()<br> BCIS_BeforeColonAfterComma,<br> /// Constructor()<br> /// : initializer1()<br> /// , initializer2()<br> BCIS_BeforeColonAndComma,<br> /// Constructor() :<br> /// initializer1(),<br> /// initializer2()<br> BCIS_AfterColonAndComma<br> };<br><br> /// \brief Breaking and alignment style for constructor initializers<br> BreakConstructorInitializersStyle BreakConstructorInitializers;<br><br></div></div>
<br></div></div>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div>