<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Arial","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">Thank you all for applying it so quickly.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">Kevin<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Reid Kleckner [mailto:rnk@google.com]
<br>
<b>Sent:</b> Friday, August 22, 2014 10:03 AM<br>
<b>To:</b> Hans Wennborg<br>
<b>Cc:</b> Smith, Kevin B; David Majnemer; cfe-dev@cs.uiuc.edu<br>
<b>Subject:</b> Re: [cfe-dev] Clang for windows<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Kevin, thanks for the patch!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Aug 22, 2014 at 10:02 AM, Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>> wrote:<o:p></o:p></p>
<div>
<p class="MsoNormal">I went ahead and added these in r216270.<o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Aug 22, 2014 at 9:37 AM, Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>> wrote:<o:p></o:p></p>
<div>
<p class="MsoNormal">On Thu, Aug 21, 2014 at 2:38 PM, Smith, Kevin B <<a href="mailto:kevin.b.smith@intel.com" target="_blank">kevin.b.smith@intel.com</a>> wrote:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">> I was playing around with CLANG for windows (clang-cl.exe) and noticed that this doesn't support<br>
> _int64, but that it does support __int64. For Microsoft compiler both __int64 and _int64 are recognized<br>
> as a keyword and basic type.<o:p></o:p></p>
</div>
<p class="MsoNormal">[...]<o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
> $ svn diff<br>
> Index: include/clang/Basic/TokenKinds.def<br>
> ===================================================================<br>
> --- include/clang/Basic/TokenKinds.def (revision 216129)<br>
> +++ include/clang/Basic/TokenKinds.def (working copy)<br>
> @@ -558,6 +558,7 @@<br>
> ALIAS("_uuidof" , __uuidof , KEYMS | KEYBORLAND)<br>
> ALIAS("_inline" , inline , KEYMS)<br>
> ALIAS("_declspec" , __declspec , KEYMS)<br>
> +ALIAS("_int64" , __int64 , KEYMS)<br>
><br>
> // Borland Extensions which should be disabled in strict conformance mode.<br>
> ALIAS("_pascal" , __pascal , KEYBORLAND)<o:p></o:p></p>
</div>
<p class="MsoNormal">Thank you for the patch! Yes, this looks like the right approach. We<br>
should do the same for _int8, _int16 and _int32. Like Richard pointed<br>
out, this needs a test (test/Lexer/ms-extensions.c is probably a good<br>
place). Would you like to add this to your patch, and then we can<br>
commit it for you?<br>
<br>
(David pointed out that the single-underscore variants of these types<br>
aren't available in MSVC with /Za, so maybe one day we should consider<br>
not exposing them with -fms-extensions by default.)<br>
<br>
Thanks,<br>
Hans<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>