<div dir="ltr">Richard, as this patch doesn't apply cleanly any more - can you outline what you were trying to do in SourceManager.h? I have a hard time figuring out which places that use FileEntry now need to use FileName...<div>
<br></div><div>Cheers,</div><div>/Manuel</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 5, 2014 at 4:51 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">As this is blocking us, I'm taking a stab at it...</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jul 30, 2014 at 12:04 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div>On Mon, Jul 28, 2014 at 11:40 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><p dir="ltr"><br>
On 28 Jul 2014 17:57, "Ben Langmuir" <<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>> wrote:<br>
><br>
><br>
>> On Jul 28, 2014, at 4:37 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>> wrote:<br>
>><br>
>> On Mon, Jul 28, 2014 at 3:10 PM, Ben Langmuir <<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>> wrote:<br>
>>><br>
>>><br>
>>> > On Jul 28, 2014, at 4:31 AM, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>> wrote:<br>
>>> ><br>
>>> > Hi Richard,<br>
>>> ><br>
>>> > while working with module maps for layering checks a problem with __FILE__ we noticed triggered a couple of questions.<br>
>>> ><br>
>>> > The problem is that __FILE__ uses the path of the first 'stat' call (as that is how FileManager::getFile() works).<br>
>>><br>
>>> I was thinking about this a while ago and independently of this issue I would really like to change this behaviour at some point. The name of a file is a property of how you look it up, not an intrinsic part of the file itself.<br>
>><br>
>><br>
>> I agree. We have incorrectly conflated the notion of the file identity (inode) with the directory entriy, and we can't tell the two apart. This leads to weird behavior in a number of places. For instance:<br>
>><br>
>> a/<br>
>> x.h: #include "y.h"<br>
>> y.h: int a = 0;<br>
>> b/<br>
>> x.h: symlink to a/x.h<br>
>> y.h: int b = 0;<br>
>> main.c:<br>
>> #include "a/x.h"<br>
>> #include "b/x.h"<br>
>> int main() { return a + b; }<br>
>><br>
>> On a correct compiler, this would work. For clang, it fails, because b/x.h's #include finds a/y.h, because we use the path by which we first found x.h as the One True Path to x.h. (This also leads to wrong __FILE__, etc.)<br>
>><br>
>> I tried fixing this ~2 years ago by splitting FileEntry into separate dentry and inode classes, but this rapidly snowballed and exposed the same design error being made in various other components.<br>
><br>
><br>
> Interesting. My motivation was keeping track of virtual and “real” paths for the VFS, which is a special case of the above. Maybe we can sink the dentry/inode down to the VFS layer eventually? Getting symlinks and “..” entries to work in the VFS make a lot more sense when we have explicit dentries rather than inferring from the file path.<br>
><br>
> I’d be interested in what issues you ran into here if you remember.</p>
</div><p dir="ltr">I'll see if I can dig out my patch tomorrow.</p></blockquote></div></div><div>Attached is my WIP patch from (as it turns out) over 2 years ago. My (very) hazy memories were that we had quite a few different places where people were using FileEntry*s for things, and neither a dentry nor an inode seemed like the "right" thing. I don't remember any more details than that. There were also places where we would need to just make a decision, such as: what should #pragma once use as its key? (I think dentry is the right answer here, since the same file found in different directories might mean different things, but that answer may break some people who use #pragma once and don't also have include guards. Conversely, it fixes some builds on content-addressed file systems.)<br>
</div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>