<div dir="ltr">FYI, I've requested a revert.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 1:02 PM, Jack Howarth <span dir="ltr"><<a href="mailto:howarth.mailing.lists@gmail.com" target="_blank">howarth.mailing.lists@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ismail,<div>     Unfortunately that doesn't address the actual bug. The problem code is in </div><div>
<br></div><div><div><pre style="margin-top:0px;margin-bottom:0px;padding:8px;border:1px solid rgb(241,196,15);background-color:rgb(253,245,212);color:rgb(0,0,0);overflow:auto;font-family:Monaco,monospace;font-size:10px"><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,64,18)">set</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">out_files</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">)</span>
<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,64,0)">foreach</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">f</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">files</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">)</span>
  <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,64,18)">set</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">src</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">CMAKE_CURRENT_SOURCE_DIR</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}/</span>$<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">f</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">)</span>
  <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,64,18)">set</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">dst</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">output_dir</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}/</span>$<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">f</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">)</span>
  <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,64,18)">add_custom_command</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">OUTPUT</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">dst</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span>
    <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">DEPENDS</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">src</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span>
    <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">COMMAND</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">CMAKE_COMMAND</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">-</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">E</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">copy_if_different</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">src</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">dst</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">}</span>
    <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">COMMENT</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(118,101,16)">"Copying clang's ${f}..."</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">)</span>
  <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,64,0)">list</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">APPEND</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">out_files</span> $<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">{</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">dst</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">})</span>
<span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,64,0)">endforeach</span><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">(</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(0,10,101)">f</span> <span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)">)</span></pre>

</div></div><div><span style="border-bottom-width:1px;border-bottom-style:solid;border-bottom-color:transparent;color:rgb(170,34,17)"><br></span></div><div>of lib/Headers/CMakeLists.txt which fails to create the machine subdirectory during 'make install'. </div>

<div>The entries for machine/_stdint.h and machine/_types.h in files are reduced to just _stdint.h and </div><div>_types.h when the those files entries are copied. This is the bug that need to be fixed and not</div><div>
hacked around.</div><span class="HOEnZb"><font color="#888888">
<div>         Jack</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 1:32 PM, Ismail Pazarbasi <span dir="ltr"><<a href="mailto:ismail.pazarbasi@gmail.com" target="_blank">ismail.pazarbasi@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Fri, Jul 18, 2014 at 5:48 PM, Jack Howarth<br>
<<a href="mailto:howarth.mailing.lists@gmail.com" target="_blank">howarth.mailing.lists@gmail.com</a>> wrote:<br>
>     I haven't seen this discussed outside of my bug report…<br>
><br>
> <a href="http://llvm.org/bugs/show_bug.cgi?id=20326" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=20326</a><br>
><br>
> and the later comments on…<br>
><br>
> <a href="http://reviews.llvm.org/D3908" target="_blank">http://reviews.llvm.org/D3908</a><br>
><br>
> but the commit of r212689…<br>
><br>
> <a href="https://www.mail-archive.com/cfe-commits@cs.uiuc.edu/msg100897.html" target="_blank">https://www.mail-archive.com/cfe-commits@cs.uiuc.edu/msg100897.html</a><br>
><br>
> has broken the darwin targets for clang via blockage of the proper use of<br>
> the<br>
> system _stdint.h and _types.h headers by the newly added clang versions.<br>
> This should be a release blocker for branching 3.5 until it is resolved, no?<br>
> Deleting the installed /sw/opt/llvm-3.5.0/lib/clang/3.5.0/include/_stdint.h<br>
> and<br>
> /sw/opt/llvm-3.5.0/lib/clang/3.5.0/include/_types.h files eliminates the<br>
> breakage<br>
> so perhaps the best solution is not to have those files installed at all<br>
> outside<br>
> of the freebsd target.<br>
> Jack<br>
><br>
</div></div>> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
><br>
<br>
Great timing, I was planning to write about this just a few minutes<br>
ago. I didn't investigate which commit broke it. I have prepared a<br>
tiny patch that I applied locally. basically, on top of the header<br>
file:<br>
<br>
#if defined(__APPLE__)<br>
#include_next<_types.h><br>
#endif<br>
<br>
I guess we can address this issue either with something like my patch<br>
or by skipping installation on darwin.<br>
<br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>