<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><blockquote type="cite"><div>On Jun 19, 2014, at 5:08 PM, Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr">Actually, upon closer inspection, nobody even adds any temporary files to this. Ever.</div></div></blockquote><div><br></div><div>ASTUnit::addTemporaryFile doesn’t seem that is getting used, but ASTUnit itself calls ‘setPreambleFile()’ which registers the precompiled preamble file with OnDiskData to be removed.</div><div><br></div><div>What are you trying to fix ?</div><br><blockquote type="cite"><div><div dir="ltr"> Is this used for some kind of out-of-tree support? If so, it seems reasonable to require that anyone who wants this implement this in their own code. Maybe clang shouldn't even have this. <div>
<br></div><div>Does anyone depend on this functionality and object to me deleting it?</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jun 19, 2014 at 5:02 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Question for the wider list: Can someone explain ASTUnit's use temporary files? Do we only ever open the files once and then that's it? Or is there a chance of passing the filename around to someone else, who will then try to open it again? Are these normal temporary files, in the sense that they're expected to be always closed on process exit?</div>
<div><br></div>Question for Argyrios: I'm looking at a fairly old revision you submitted, r159664. The commit message here is as follows:<div><br></div><div><div> [libclang] Protect against a race condition where a thread</div>
<div> may be destroying an ASTUnit while cleanupOnDiskMapAtExit is</div><div> getting called.</div><div><br></div><div> <a href="rdar://11781241">rdar://11781241</a></div><div><br></div></div><div>Unfortunately I can't see this rdar link, so I don't have any more context. Can you elaborate on this race condition? My guess is that we're running multiple threads, someone calls ::exit(), and then the running threads race against this atexit handler.</div>
<div><br></div><div>I'd like to fix this "properly", but it's difficult without have more context about this race.</div><div><br></div><div><br></div></div>
</blockquote></div><br></div>
</div></blockquote></div><br></body></html>