<div dir="ltr">Philip,<div> Also, it would be quite unfortunate if the previous partial merge of clang-omp, which I assume was done to make the -fopenmp/-lgomp support in clang trunk more usable, in the end became a major impediment towards getting the clang-omp changes into clang trunk in time for 3.5's release.</div>
<div> Jack</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 28, 2014 at 9:21 PM, Jack Howarth <span dir="ltr"><<a href="mailto:howarth.mailing.lists@gmail.com" target="_blank">howarth.mailing.lists@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Philip,<div> From observing many merges in FSF gcc over the years, it is crazy to take a new branch, selectively pull in small sections and then take long breaks where the two start to rapidly fork. If a branch is to be merged, the process should at least be scheduled such that the process will take place over a known period of time so attempts can be made to keep the two in sync or at least keep track of where the two have begun to diverge. At the moment, there are quite a few files introduced from clang-omp that are no longer in sync and the svn web browser access doesn't seem to allow you to easily view the commit history on individual files to see if they have been changed since the original commits.</div>
<span class="HOEnZb"><font color="#888888">
<div> Jack</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 28, 2014 at 8:25 PM, Philip Reames <span dir="ltr"><<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
I would strongly recommend that you get your current branch in sync
with clang-TOT as a first step. Once this done, you should separate
individual patches and submit them for review. Based on previous
history, the community is unlikely to accept a single massive change
set. <br>
<br>
p.s. The tone of your last sentence is less than ideal. These are
the folks actually working on getting the work you are interested
merged into upstream. You should thank them, not critique them.
(I'm not one of them, btw.)<br>
<br>
Philip<div><br>
<br>
<div>On 05/28/2014 03:19 PM, Jack Howarth
wrote:<br>
</div>
</div><blockquote type="cite"><div>
<div dir="ltr"> <font face="Calibri, sans-serif"><span style="font-size:15px">Andrey Bokhanko expressed interest in
getting the clang-omp merge done in time for the 3.5 release
but wants guidance on the process. I suggested starting with
the creation a new clang-omp branch upstream rebased on
clang trunk for generation of merge patch. Unfortunately
merging the current changes from the clang-omp (based on
clang 3.4) to a clang-omp (based on clang trunk) looks very
difficult as selective patches have been committed into
clang trunk from clang-omp and don't appear to have been
kept synchronized with the current changes from upstream.
Does anyone know if these new files from previous commits
out of clang-omp contain any local changes which haven't
been back ported to clang-omp? It would seem that postponing
this merge will just make the process harder as time goes on
if selective merges from clang-omp into clang trunk continue
in the interim. Hopefully the folks who did the original
selective commits would help detangle this mess.</span></font>
<div>
<font face="Calibri, sans-serif"><span style="font-size:15px">
Jack</span></font></div>
</div>
<br>
<fieldset></fieldset>
<br>
</div><pre>_______________________________________________
cfe-dev mailing list
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a>
</pre>
</blockquote>
<br>
</div>
<br>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>