<div dir="ltr"><div>On Wed, Apr 23, 2014 at 10:09 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br></div><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">
<div class="">On Thu, Apr 24, 2014 at 1:53 AM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Do you have a bot that provides an up-to-date list of these reports? </div>
</blockquote><div><br></div></div><div>No bot, but I've just updated <a href="http://llvm.org/bugs/show_bug.cgi?id=19521" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=19521</a> with the new log. </div><div>The leak from <a href="http://llvm.org/bugs/show_bug.cgi?id=19520" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=19520</a> appears over 1000 times while running check-clang,</div>
<div>so I suppressed it, all other leaks are in the log: <a href="http://llvm.org/bugs/attachment.cgi?id=12428" target="_blank">http://llvm.org/bugs/attachment.cgi?id=12428</a></div><div>Quite a few still.</div></div></div>
</div></blockquote><div><br></div><div>Down from 4200 to 1500 (or 2500, if you don't count the 1000 suppressed), that's good progress :-)</div><div><br></div><div>Many of these are in CGDebugInfo and some in CodeGenFunction – if someone who knows that code could look at these (it's probably just 2-4 bugs), that'd be a huge help.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div> </div><div><br></div><div>There are also 14 leaks while running check-llvm, added a separate log: </div>
<div><a href="http://llvm.org/bugs/attachment.cgi?id=12429" target="_blank">http://llvm.org/bugs/attachment.cgi?id=12429</a><br></div><div class=""><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">r207031 probably fixes many of the convertCommentToXML stacks.</div></blockquote></div><div>Thanks for this and all the other fixes! </div><div><div class="h5"><div><br></div><div>--kcc </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Wed, Apr 23, 2014 at 6:25 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div><div dir="ltr"><div>Manuel mentions that clang has some intentional leaks.<br>
</div><div>That's right, and we handle them using BuryPointer (./lib/Frontend/CompilerInvocation.cpp).</div>
<div>So if there are more *intentional* leaks we need to bury them too to let LSan find the interesting ones.</div>
<div><br></div><div>--kcc </div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 23, 2014 at 4:25 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">Hi, </span><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px"><div><div>TL;DR: there are tons of leaks in Clang, please help us fix them. <br>
<div><br></div><div>We have a <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap" target="_blank">build bot</a> that runs clang bootstrap under <a href="http://clang.llvm.org/docs/AddressSanitizer.html" target="_blank">AddressSanitizer</a> (ASan). </div>
<div><a href="http://clang.llvm.org/docs/LeakSanitizer.html" target="_blank">LeakSanitizer</a> (LSan, a leak detector that runs as part of ASan) is enabled on that bot,<br></div><div>but as we've learned today only on part of the bootstrap actually runs LSan.</div>
<div>LSan is enabled by the env. var ASAN_OPTIONS=detect_leaks=1 and we have <br></div><div>this env. var. set on the bot so the 3-rd stage build uses it.</div><div>However the lit runner clears the environment and the lit</div>
<div>tests were not running under lsan until today, when I tried to enable lsan by default.</div><br>This has discovered tons of leaks and I reverted the change. <br>The leaks happen in various modes that are not exercised during regular self-compilation on linux, <br>
e.g. static analyzer, -emit-llvm, Windows ABI, etc.<br>I've filed a few bugs (19520 19522 19523 19524) but there are dozens more reports left. <br><br></div></div>If you care about leaks in clang, please check <a href="http://llvm.org/bugs/attachment.cgi?id=12423" target="_blank">http://llvm.org/bugs/attachment.cgi?id=12423</a> </div>
<div style="font-family:arial,sans-serif;font-size:13px">and see if any of these leaks are in your code. <br><br>Thanks, <br><br>--kcc</div></div>
</blockquote></div><br></div></div></div></div>
<br></div></div>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>