<div dir="ltr">I'm waiting impatiently for this patch to land ;)<div>Any progress here? Jordan, AFAIU the ball is on your side?<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 6, 2014 at 8:47 PM, Alex McCarthy <span dir="ltr"><<a href="mailto:alexmc@google.com" target="_blank">alexmc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for taking a look, Jordan, I really appreciate the extra eyes. Please find an updated patch attached.<div>
<br></div><div>I misread the test in temporaries.cpp, thanks. I've restored the test so it's testing the right thing: it still fails and I'm currently stumped. I've produced some simpler test cases that are much easier to analyze, but I still don't understand how this incorrect behavior is triggered. I've also added more CFG dumps to temp-obj-dtors-cfg-output.cpp.test to see if anything stands out. I've also added a lot of debug output which clearly has to be removed before submission. I'd really appreciate any more advice you have here, and I'll keep (slowly) debugging in the mean time.</div>
<div><br></div><div>The array processing while loop I added to ExprEngineCxx.cpp's ::VisitCXXDestructor was an attempt to fix the crash that I found when processing initializer_lists of temporary objects. I added a new test to dtor-xx11.cpp to cover this case:<br>
<div><br></div><div>namespace Cxx11BraceInit {</div><div> struct Foo {</div><div> ~Foo() {}</div><div> };</div><div><br></div><div> void testInitializerList() {</div><div> for (Foo foo : {Foo(), Foo()}) {}</div>
<div> }</div><div>}</div></div><div><br></div><div>Without the array special casing, clang crashes while parsing this:</div><div>clang: third_party/llvm/llvm/tools/clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:322: void clang::ento::ExprEngine::VisitCXXDestructor(clang::QualType, const clang::ento::MemRegion *, const clang::Stmt *, bool, clang::ento::ExplodedNode *, clang::ento::ExplodedNodeSet &): Assertion `RecordDecl && "Only CXXRecordDecls destructors can be processed"' failed.<br>
</div><div><br></div><div>I've updated the special casing to be a bit simpler, but I think it (or something like it) is necessary to avoid crashing on initializer_lists. What do you think?</div><div><br></div><div>Your recommendation of skipping destructors in VisitCXXConstructExpr worked perfectly: I've updated getRegionForConstructedObject in ExprEngineCXX.cpp to recurse when it finds a destructor, and that fixed the spurious garbage return value warnings, which now means that this patch eliminates all large scale false positives on this project's codebase. Thanks for your help!</div>
<div><br></div><div>If there are any parts of this change that you'd like to split out and individually commit (like the dtor handling in PathDiagnostic.cpp) that sounds fine to me. I'm happy with whatever patching combination you'd prefer if you help me through the splitting and committing process.</div>
<div><br></div><div>Thanks again for your help with this!</div></div><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div><span style="color:rgb(153,153,153)">-Alex</span><br></div></font></span><div>
<div class="h5">
<br><br><div class="gmail_quote">On Tue, Mar 4, 2014 at 7:45 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Wow, thanks for working on this, Alex. Unfortunately I think there may be a few more problems than simply turning things back on. In particular, from test/Analysis/temporaries.cpp:</div>
<div><br></div><div><div> if (compute(i == 5 &&</div><div> (i == 4 || i == 4 ||</div><div> compute(i == 5 && (i == 4 || check(NoReturnDtor()))))) ||</div><div> i != 4) {</div>
<div>- clang_analyzer_eval(true); // no warning, unreachable code</div><div>+ clang_analyzer_eval(true); // expected-warning{{TRUE}} (possible when i=6)</div><div> }</div></div><div><br></div><div>i cannot equal 6 at this point in the code; testConsistencyNested has a line earlier that says "if (i != 5) return". So we're not getting the correct behavior here—either the destructor isn't ending up in the right place in the CFG, or something is invalidating the value of 'i' that shouldn't be. I would guess it's the former, since this series of tests were designed to check Pavel's reworking of the CFG.</div>
<div><br></div><div>This part confuses me:</div><div><br></div><div><div>+ while (const ArrayType *ArrayType = Ctx.getAsArrayType(ObjectType)) {</div><div>+ ObjectType = ArrayType->getElementType();</div><div>
+ VisitCXXDestructor(ObjectType, Dest, S, IsBaseDtor, Pred, Dst);</div>
<div>+ }</div></div><div><br></div><div>For a multidimensional array of, say, Foo, this visits "array", "array[0]", "array[0][0]", etc, down to the single element case. In addition, visiting "array[0]" will <i>also</i> trigger a destruction of "array[0][0]", etc., since this loop happens as the very first thing in VisitCXXDestructor.</div>
<div><br></div><div>I would just leave the FIXME as is here, and not worry about this.</div><div><br></div><div><div> // FIXME: We need to run the same destructor on every element of the array.</div><div> // This workaround will just run the first destructor (which will still</div>
<div> // invalidate the entire array).</div></div><div><br></div><div>And then we have your new test case:</div><div><br></div><div><div>+ //TODO: figure out why this case causes an unexpected "Undefined or garbage value returned to caller" warning</div>
<div>+ bool testNamedCustomDestructor() {</div><div>+ if (CheckCustomDestructor c = CheckCustomDestructor())</div><div>+ return true;</div><div>+ return false;</div><div>+ }</div></div><div><br></div><div>First of all, nicely discovered. I'm not immediately sure what's wrong here, but let's take a look at the CFG:</div>
<div><br></div><div><div style="margin:0px;font-size:11px;font-family:Menlo;color:rgb(76,47,45);background-color:rgb(223,219,196)"><div style="margin:0px;color:rgb(150,150,0)"><b> [B3]</b></div><div style="margin:0px"> 1: CheckCustomDestructor() (CXXConstructExpr, struct CheckCustomDestructor)</div>
<div style="margin:0px"> 2: [B3.1] (BindTemporary)</div><div style="margin:0px"> 3: [B3.2] (ImplicitCastExpr, NoOp, const struct CheckCustomDestructor)</div><div style="margin:0px"> 4: [B3.3]</div><div style="margin:0px">
5: [B3.4] (CXXConstructExpr, struct CheckCustomDestructor)</div><div style="margin:0px"> 6: ~CheckCustomDestructor() (Temporary object destructor)</div><div style="margin:0px"> 7: CheckCustomDestructor c = CheckCustomDestructor();</div>
</div></div><div><br></div><div>B3.1 is the actual creation of the temporary. B3.5 is the copy constructor required by the C++ standard to copy the temporary into 'c'. B3.6 is the destruction of the temporary, and B3.7 is the actual VarDecl for 'c'. (The block then goes on to call 'operator bool' on 'c' and then do the if-branch.)</div>
<div><br></div><div>The current handling of constructors for VarDecls is a bit hacky. If you look in ExprEngine::VisitCXXConstructExpr, you'll notice it tries to look ahead to the next CFG element to see if it's constructing a particular variable. If so, it sets the target region to that variable. The trouble is, there's now a destructor between B3.5 and B3.7, so my guess is that the analyzer has decided it's <i>not</i> constructing a variable. I am okay with cheating right now by skipping over destructor CFG elements in VisitCXXConstructExpr, but I haven't thought about if there's a better way to tell that a particular CXXConstructExpr goes with a particular VarDecl.</div>
<div><br></div><div>As far as this part goes...</div><div><br></div><div><div>- case CFGElement::TemporaryDtor:</div><div>+ case CFGElement::TemporaryDtor: {</div><div>+ const CFGTemporaryDtor &Dtor = Source.castAs<CFGTemporaryDtor>();</div>
<div>+ return PathDiagnosticLocation(Dtor.getBindTemporaryExpr(), SM, CallerCtx);</div><div>+ }</div></div><div><br></div><div>...that seems like a good obvious change, and I'm happy to commit that (or for you to commit that) without turning anything else on. :-)</div>
<div><br></div><div>I know this is a lot to throw at you at once, but please continue to e-mail me with questions and progress. I'm very happy that someone is able to put time into this.</div><div><br></div><div>Jordan</div>
<div><br></div><br><div><div><div><div>On Mar 2, 2014, at 0:41 , Alex McCarthy <<a href="mailto:alexmc@google.com" target="_blank">alexmc@google.com</a>> wrote:</div><br></div></div><blockquote type="cite">
<div><div><div dir="ltr">Hi all,<div><br></div><div><span>I'm running clang's static analyzer on a C++ codebase at Google. I saw a roughly a 50% false positive rate which stemmed from the analyzer not recognizing temporary object destructors: this issue is discussed in some length in another thread, which mentions a similar error rate on the Chromium codebase: <a href="http://comments.gmane.org/gmane.comp.compilers.clang.devel/33901" target="_blank">http://comments.gmane.org/gmane.comp.compilers.clang.devel/33901</a></span></div>
<div><br></div><div><span>Starting from Pavel's work which was reverted in <a href="http://llvm-reviews.chandlerc.com/rL186925" target="_blank">http://llvm-reviews.chandlerc.com/rL186925</a> , I've put together a new patch (see attachment) that attempts to fix temporary object destructor handling.</span></div>
<div><span><br></span></div><div><span>This new patch fixes all of the new regression tests added after Pavel's change was reverted, notably including <a href="http://llvm-reviews.chandlerc.com/rL187133" target="_blank">http://llvm-reviews.chandlerc.com/rL187133</a> . I've also fixed some other crashes, including a crash when processing an array of temporary objects use in a C++11 initializer_list, covered by a new regression test in </span>cfe/test/Analysis/dtor-cxx11.cpp . And most importantly, running clang with this patch eliminates the 50% false positive rate I saw previously (from ~800 warnings to ~400 across the ~1700 file codebase).</div>
<div><span><br></span></div><div><span><br></span></div><div><span>Now for the bad news:</span></div><div><span><br></span></div><div><span>This patch introduces a new regression which wasn't covered by existing tests: named temporaries declared and used within if statements are considered dead while they're still being used, which results in "</span>Undefined or garbage value returned to caller" errors. I've added regression tests to test/Analysis/dtor.cpp to cover this case, which currently fail. I've also updated test/Analysis/temp-obj-dtors-cfg-output.cpp with relevant CFG dumps to try to debug the problem. This new false positive is much nosier than the ones this patch fixes: the only advantage to the current patch as-is is that the garbage return value warnings are emitted in a small collection of header files, making them much easier to ignore en masse.</div>
<div><br></div><div>I don't have any compiler experience, so I'm moving slowly in the clang codebase and could use some help understanding where to look next. I've mostly been handling each crash or error as I find it, but I don't have a high level understanding of the impact or context of my change. In particular, I don't know how to read the CFG dumps I've generated, so I'm not sure where things are going wrong. Ted, Jordan, and Anna: Manuel Klimek mentioned that you've looked into this issue at length. Do have any advice on what I'm doing wrong, or could you suggest other approaches I might be able to try? Anything you can think of that can speed up my search for a fix would be greatly appreciated.</div>
<div><br></div><div>If we can get this patch working, it should address the following issues:</div><div><a href="http://llvm.org/bugs/show_bug.cgi?id=15599" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=15599</a> </div>
<div><span><a href="http://llvm.org/bugs/show_bug.cgi?id=16664" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=16664</a></span></div><div><span></span><span><a href="http://llvm.org/bugs/show_bug.cgi?id=18159" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=18159</a> (not sure, this bug is referenced by a newly fixed test in </span>test/Analysis/temporaries.cpp)</div>
<div><br></div><div>Thanks for your help,<br clear="all"><div><span style="color:rgb(153,153,153)">-Alex McCarthy</span><br></div>
</div></div>
</div></div><span><temporary-destructors.patch></span></blockquote></div></div></blockquote></div></div></div></div></blockquote></div><br>
</div></div></div>