<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Feb 24, 2014 at 10:49 PM, Anna Zaks <span dir="ltr"><<a href="mailto:ganna@apple.com" target="_blank">ganna@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Is it possible to have the same (similar) positive results just by teaching the analyzer about the custom assertions? If yes, I’d suggest you to use that as a patch on your private branch. Or you might consider teaching the TOT analyzer to accept a list of such assertions. This could be used in cases the source code cannot be annotated with ‘noreturn'.<div>
<br></div><div>As Jordan and Ted had mentioned, just reverting the patch results in unexpected behavior in both ObjC and C++.<br><div>See cfe/trunk/test/Analysis/live-variables.cpp for the C++ example. There, even though the dereference of 'p’ is guarded by ‘p != 0’, we reported a null pointer dereference.</div>
</div></div></blockquote><div><br></div><div>Hi Anna,</div><div><br></div><div>thx for the tip; we'll basically evaluate each warning on its own (we want > 90% true positive rate) and see how far we can get without needing to patch, or which warnings the patch affects in which ways.</div>
<div><br></div><div>Cheers,</div><div>/Manuel</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><span class="HOEnZb"><font color="#888888"><div>
<br></div><div>Anna.</div></font></span><div><div class="h5"><div><br><div><div><div>On Feb 10, 2014, at 2:38 AM, Daniel Connelly <<a href="mailto:dconnelly@google.com" target="_blank">dconnelly@google.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr"><div>(cc: <a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>, <a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>)</div><div><br></div>
As a bit of a follow-up, we are still very interested in getting this worked out, as it's a significant barrier to the Analyzer's usefulness. All of our C++ projects make extensive use of custom assertions. For example,<div>
<br></div><div>CHECK(condition) << "something happened with the hydrospanners";</div><div><br></div><div>which logs a message and kills the program if the condition isn't met. None of these custom assertions are pruning code paths due to the missing conditional expression support. For example, when building Chromium, <span style="font-size:13px;font-family:arial,sans-serif">the difference between running without and with the reverted patch is 1982 reported errors vs. 3210 reported errors. This number is a bit conservative, since we also have this problem in dependent libraries that don't (but could) use analyzer_noreturn on their assertions; the real cost is that about 50% of all errors reported by the analyzer are false positives of this form.</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jan 31, 2014 at 11:32 AM, Daniel Connelly <span dir="ltr"><<a href="mailto:dconnelly@google.com" target="_blank">dconnelly@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">After digging into this for a couple of weeks across the 2013/2014 boundary, I now doubt that my 20% time will be enough to properly implement this support. Anybody who's interested should feel free to work on this instead, as I'll not be moving forward with it. Jordan, thanks for the pointers and the summary of the problem!</div>
<div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Wed, Dec 18, 2013 at 1:55 AM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div><div>On Dec 16, 2013, at 6:57 , Daniel Connelly <<a href="mailto:dconnelly@google.com" target="_blank">dconnelly@google.com</a>> wrote:</div>
<br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>
On Fri, Dec 13, 2013 at 7:13 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
</div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div>
<br></div><div>In discussing the first problem, Ted and Anna realized that the liveness information for nested && and || expressions was still incorrect: the outermost expression may potentially depend on all of the inner expressions, but that means that those sub-expressions are <i>always</i> considered live (since expressions are marked dead, in a reverse analysis, at the point of evaluation, and there are paths that don't evaluate a particular sub-expression in a complex logical expression). This wasn't an issue before because && and || didn't actually use those expressions to compute their value, but it's still incorrect.</div>
</div></blockquote><div><br></div><div>Is this <a href="http://llvm.org/bugs/show_bug.cgi?id=18159" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=18159</a> ?</div></div></div></div></div></blockquote><div><br></div>
Yes.</div><div><br></div><div><div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Thanks for the overview. This is all pretty new to me, so I'm going to dig into the problem for a couple of days and hopefully come up with some intelligent questions.</div>
</div></div></blockquote></div><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><br></div><div class="gmail_quote">Sorry for the blast of information. If you want an easier place to start playing with the analyzer, you could try hacking on productizing SimpleStreamChecker. (And if you haven't watched our talk from last year's LLVM dev meeting, I definitely suggest taking the time to do so. It's aimed at checker writers, but still describes the general structure of the analyzer. It's linked near the top of <a href="http://clang-analyzer.llvm.org/checker_dev_manual.html" target="_blank">http://clang-analyzer.llvm.org/checker_dev_manual.html</a>)</div>
<span><font color="#888888"><div class="gmail_quote"><br></div><div class="gmail_quote">Jordan</div></font></span></div></div></div></div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><div>
-- <br><div dir="ltr">
<span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Daniel Connelly |</span><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer <span><span style="font-size:15px;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">–</span></span> Chrome |</span><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(0,153,57);padding-top:2px;margin-top:2px"> <a href="mailto:dconnelly@google.com" target="_blank">dconnelly@google.com</a> |</span><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> </span><span style="font-size:inherit;font-family:Times"><br>
</span><br><div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Google Germany GmbH</span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Dienerstr. 12</span></font></div>
<div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">80331 München</span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px"><br></span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Registergericht und -nummer: Hamburg, HRB 86891</span></font></div>
<div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Sitz der Gesellschaft: Hamburg</span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Geschäftsführer: Graham Law, Christine Elizabeth Flores</span></font></div>
</div><div><br></div></div>
</div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Daniel Connelly |</span><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer <span><span style="font-size:15px;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">–</span></span> Chrome |</span><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(0,153,57);padding-top:2px;margin-top:2px"> <a href="mailto:dconnelly@google.com" target="_blank">dconnelly@google.com</a> |</span><span style="color:rgb(85,85,85);font-family:sans-serif;font-size:small;line-height:1.5em;border-width:2px 0px 0px;border-style:solid;border-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> </span><span style="font-family:Times;font-size:inherit"><br>
</span><br><div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Google Germany GmbH</span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Dienerstr. 12</span></font></div>
<div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">80331 München</span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px"><br></span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Registergericht und -nummer: Hamburg, HRB 86891</span></font></div>
<div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Sitz der Gesellschaft: Hamburg</span></font></div><div><font color="#555555" face="sans-serif"><span style="line-height:19.5px">Geschäftsführer: Graham Law, Christine Elizabeth Flores</span></font></div>
</div><div><br></div></div>
</div>
</blockquote></div><br></div></div></div></div></div></div></blockquote></div><br></div></div>