<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 30 January 2014 21:50, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I don't see any compelling reason to split the sanitizers out today.</div></div></div></div></blockquote><div><br></div><div>Clear, next.</div><div>
<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I think the sanitizer guys would probably take a patch to CMakeLists.txt to disable the sanitizer RTLs.</div>
</div></div></div></blockquote><div><br></div><div>Right. I'll first make it build and test, than I'll disable via a flag, since other people can work in parallel to make it work on ARM.</div><div><br></div><div><br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div>I'm told that ASan supports ARM, but it's maybe not production quality, so I don't think disabling all sanitizers on non-x86 architectures will work.<br></div></div></div></div></blockquote><div><br></div>
<div>I hear Android folks use it, this is why I want to enable them by default. Even if the tests don't mean much, at least there's a seed from where they can pick that up and complete the port.</div><div><br></div>
<div>I'm fine on building them on my own, but buildbots and release builds should not need to, if it's not suitable.</div><div> </div></div>Thanks, that answers all my questions. I'll proceed with my changes.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">--renato</div></div>