<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri","sans-serif";
mso-fareast-language:SV;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="SV" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US" style="color:black">Hi,</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"> </span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">There is a division by zero check where the denominator value is already known. I would like some feedback on a new static check for division by zero I intend to write where the value isn’t known
yet.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">It shall catch scenarios where the division is made before checking it against a value. To start with it will have to be directly after the division.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">e.g <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">x = 100 / y;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">if (y == 0)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">I plan to do it by:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.5pt;color:black">1. When a division is reached where the denominator is a variable with unknown value, “mark” the denominator variable.</span><span lang="EN-US" style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.5pt;color:black">2. When reaching a condition that checks if a variable is 0, check if the variable in the condition is “marked”.</span><span lang="EN-US" style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">3. Report bug</span><span lang="EN-US" style="color:black"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">I guess RecursiveASTVisitor is best for this?<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black">Is there perhaps a better way to do this that would allow me to follow the variable from division to check so that it doesn't have to be directly after?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-US">//Anders</span><span style="font-size:8.0pt;font-family:"Courier New";mso-fareast-language:SV"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>