<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Source locations are measured in bytes, not in characters, with the assumption that most editors are better-equipped to deal with byte offsets. So I think this is correct.</div><div><br></div><div>Jordan</div><div><br></div><br><div><div>On Jan 7, 2014, at 0:36 , Anton Smirnov <<a href="mailto:dev@antonsmirnov.name">dev@antonsmirnov.name</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I've just extracted/build and installed llvm, clang, compiler-rt etc for branches/release_34 and this issue relates to 3.4 release too.<div>IMHO it's pretty important issue that should be fixed before 3.4 release..</div>
<div><br></div><div>Regards, Anton.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014/1/7 Anton Smirnov <span dir="ltr"><<a href="mailto:dev@antonsmirnov.name" target="_blank">dev@antonsmirnov.name</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">bug report:<div><a href="http://llvm.org/bugs/show_bug.cgi?id=18405" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=18405</a><br>
</div><div><br></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
2014/1/7 Anton Smirnov <span dir="ltr"><<a href="mailto:dev@antonsmirnov.name" target="_blank">dev@antonsmirnov.name</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hello.<div><br></div><div>I've just found that if UnsavedFile has russian characters in it's content, SourceLocation's start/end is calculated wrong - each symbol length is calculated to be 2 bytes instead of 1. This leads to wrong end and all other tokens locatoin while clang_tokenize().</div>
<div><br></div><div>I've check it on 3.3 on mac and linux (android via JNI) since i can't see 3.4 release (though it was scheduled to be released in december) notes and downloads.</div><div><br></div><div>Any confirmation/suggestions?</div>
<div><br></div><div>PS. I've also posted bug report but i can't see it yet.</div><div><br></div><div>Regards, Anton.</div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev<br></blockquote></div><br></body></html>