<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 6, 2013 at 2:14 PM, Will Dietz <span dir="ltr"><<a href="mailto:wdietz2@illinois.edu" target="_blank">wdietz2@illinois.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Indeed, sorry about that.  Surprised this hasn't cropped up earlier!<br>
<br>
I've committed a fix as r196612, confirmed to fix the issue by testing<br>
with -m32.<br>
<br>
* @Ismail: If you're able, confirmation that this fixes the issue for<br>
you would be appreciated to ensure this is indeed fixed.<br>
* @Richard: Should this be forwarded to the release branch?<br></blockquote><div><br></div><div>I'm not sure we really care. I'll let Bill make the call on this, but at this stage in the release, a non-functional change (fixing a testcase's expectations) doesn't seem very important. On the other hand, it doesn't seem risky =)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* When testing with -m32 I'm seeing TypeCheck/vptr.cpp fail with what<br>
seems to be whitespace specific to 64bit.  Is this an issue on i586 as<br>
well?<br>
<span class="HOEnZb"><font color="#888888"><br>
~Will<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Thu, Dec 5, 2013 at 8:34 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:<br>
> Will, is unsigned-integer-overflow one of yours?<br>
><br>
><br>
> On Thu, Dec 5, 2013 at 3:34 AM, İsmail Dönmez <<a href="mailto:ismail@donmez.ws">ismail@donmez.ws</a>> wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> I have multiple UBSAN tests failing the same way:<br>
>><br>
>>  ******************** TEST 'UndefinedBehaviorSanitizer-AddressSanitizer ::<br>
>> Integer/uadd-overflow.cpp' FAILED ********************<br>
>>  Script:<br>
>>  --<br>
>>  /home/abuild/rpmbuild/BUILD/llvm/stage2/bin/clang -fsanitize=address<br>
>> --driver-mode=g++ -DADD_I32 -fsanitize=unsigned-integer-overflow<br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp<br>
>> -o<br>
>> /home/abuild/rpmbuild/BUILD/llvm/stage2/projects/compiler-rt/lib/ubsan/lit_tests/AsanConfig/Integer/Output/uadd-overflow.cpp.tmp<br>
>> &&<br>
>> /home/abuild/rpmbuild/BUILD/llvm/stage2/projects/compiler-rt/lib/ubsan/lit_tests/AsanConfig/Integer/Output/uadd-overflow.cpp.tmp<br>
>> 2>&1 | FileCheck<br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp<br>
>> --check-prefix=CHECK-ADD_I32<br>
>>  /home/abuild/rpmbuild/BUILD/llvm/stage2/bin/clang -fsanitize=address<br>
>> --driver-mode=g++ -DADD_I64 -fsanitize=unsigned-integer-overflow<br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp<br>
>> -o<br>
>> /home/abuild/rpmbuild/BUILD/llvm/stage2/projects/compiler-rt/lib/ubsan/lit_tests/AsanConfig/Integer/Output/uadd-overflow.cpp.tmp<br>
>> &&<br>
>> /home/abuild/rpmbuild/BUILD/llvm/stage2/projects/compiler-rt/lib/ubsan/lit_tests/AsanConfig/Integer/Output/uadd-overflow.cpp.tmp<br>
>> 2>&1 | FileCheck<br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp<br>
>> --check-prefix=CHECK-ADD_I64<br>
>>  /home/abuild/rpmbuild/BUILD/llvm/stage2/bin/clang -fsanitize=address<br>
>> --driver-mode=g++ -DADD_I128 -fsanitize=unsigned-integer-overflow<br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp<br>
>> -o<br>
>> /home/abuild/rpmbuild/BUILD/llvm/stage2/projects/compiler-rt/lib/ubsan/lit_tests/AsanConfig/Integer/Output/uadd-overflow.cpp.tmp<br>
>> &&<br>
>> /home/abuild/rpmbuild/BUILD/llvm/stage2/projects/compiler-rt/lib/ubsan/lit_tests/AsanConfig/Integer/Output/uadd-overflow.cpp.tmp<br>
>> 2>&1 | FileCheck<br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp<br>
>> --check-prefix=CHECK-ADD_I128<br>
>>  --<br>
>>  Exit Code: 1<br>
>><br>
>>  Command Output (stderr):<br>
>>  --<br>
>><br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp:21:20:<br>
>> error: expected string not found in input<br>
>>   // CHECK-ADD_I64: 10000000000000000000 + 9000000000000000000 cannot be<br>
>> represented in type 'unsigned long'<br>
>>                     ^<br>
>>  <stdin>:1:1: note: scanning from here<br>
>><br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp:20:44:<br>
>> runtime error: unsigned integer overflow: 10000000000000000000 +<br>
>> 9000000000000000000 cannot be represented in type 'unsigned long long'<br>
>>  ^<br>
>>  <stdin>:1:160: note: possible intended match here<br>
>><br>
>> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/ubsan/lit_tests/TestCases/Integer/uadd-overflow.cpp:20:44:<br>
>> runtime error: unsigned integer overflow: 10000000000000000000 +<br>
>> 9000000000000000000 cannot be represented in type 'unsigned long long'<br>
>><br>
>> So the test expect to see "unsigned long" but output has "unsigned long<br>
>> long".<br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-dev mailing list<br>
>> <a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
>><br>
><br>
</div></div></blockquote></div><br></div></div>