<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Nov 11, 2013, at 9:56 AM, Alp Toker <<a href="mailto:alp@nuanti.com">alp@nuanti.com</a>> wrote:<br><div><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000">Done :-)<br>
<br>
The patchset is 532K so I've put it online:<br>
<br>
<a class="moz-txt-link-freetext" href="http://www.nuanti.com/tmp/llvm-api-stability/">http://www.nuanti.com/tmp/llvm-api-stability/</a><br>
<br>
The bulk edits are split out and noted. They were refactored with an
internal tool, so it's not a big hassle to keep this up to date
until 3.4 is out the door.<br>
<br>
A handful of fixes were needed to add support for Release+Assert
builds and these are also separate commits.<br></div></blockquote><div><br></div><div>Whoa whoa whoa. Why are you introducing an llvm_assert() macro? The use of assert in header files is not a problem for "libraries", it is things like:</div><div><br></div><div>#ifndef NDEBUG</div><div> int SomeNewVariable;</div><div>#endif</div><div><br></div><div>in a class.</div><div><br></div><div>-Chris</div><div><br></div></div></body></html>