<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Daniel,<br>
<br>
Here's a good one for you..<br>
<br>
I've recently been fixing a whole lot of lit tests in the LLVM /
clang suites that don't check anything.<br>
<br>
It was a mystery why people keep checking in tests like this:<br>
<br>
<code>// RUN: clang-check "%s" -- -target x86_64-apple-darwin10
-fasm-blocks 2>&1 |</code><code><br>
</code><code>// </code><code>FileCheck %s</code><br>
<br>
The first line will run successfully, and the second doesn't begin
with RUN so the test passes silently. Not good.<br>
<br>
Then it dawned on me -- contributors must be running clang-format
before committing, causing their RUN lines to get split up at the
line boundary.<br>
<br>
I know this isn't strictly a clang-format bug, but it's time
consuming to manually audit and find no-op tests like this after the
fact and the failure mode is insidious because these tests will
always silently pass.<br>
<br>
I was wondering if you can think of a way to exclude the test suites
from clang-format and clang-format-diff runs. Guessing this could be
tricky given that there are several different ways to run
clang-format but something needs to be done..<br>
<br>
Alp.<br>
<br>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.nuanti.com">http://www.nuanti.com</a>
the browser experts
</pre>
</body>
</html>