<div dir="ltr">That should be easy enough. We simply need a .clang-format file in the test suites removing the column limit.<div><br></div><div>Done in r194248 and r194221, respectively.<br></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Thu, Nov 7, 2013 at 9:49 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Daniel,<br>
<br>
Here's a good one for you..<br>
<br>
I've recently been fixing a whole lot of lit tests in the LLVM /
clang suites that don't check anything.<br>
<br>
It was a mystery why people keep checking in tests like this:<br>
<br>
<code>// RUN: clang-check "%s" -- -target x86_64-apple-darwin10
-fasm-blocks 2>&1 |</code><code><br>
</code><code>// </code><code>FileCheck %s</code><br>
<br>
The first line will run successfully, and the second doesn't begin
with RUN so the test passes silently. Not good.<br>
<br>
Then it dawned on me -- contributors must be running clang-format
before committing, causing their RUN lines to get split up at the
line boundary.<br>
<br>
I know this isn't strictly a clang-format bug, but it's time
consuming to manually audit and find no-op tests like this after the
fact and the failure mode is insidious because these tests will
always silently pass.<br>
<br>
I was wondering if you can think of a way to exclude the test suites
from clang-format and clang-format-diff runs. Guessing this could be
tricky given that there are several different ways to run
clang-format but something needs to be done..<span class="HOEnZb"><font color="#888888"><br>
<br>
Alp.<br>
<br>
<pre cols="72">--
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a>
the browser experts
</pre>
</font></span></div>
</blockquote></div><br></div>