<div dir="ltr">I think this generally seems like a good idea. However, I'd like to also keep the old version at least for a while for compatibility and because I think it is slightly easier to install until it can be used by Vundle etc.<div>
<br></div><div>That should however not keep us from also committing this. Either to some Github repository so it can be used by Vundle or to a separate directory inside cfe, e.g. tools/clang-format/vim. The current state where several editor integrations are just files in tools/clang-format is a mess anyway ..</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 16, 2013 at 7:14 PM, Steffen Prohaska <span dir="ltr"><<a href="mailto:prohaska@zib.de" target="_blank">prohaska@zib.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On Sep 16, 2013, at 6:04 PM, Tobias Grosser <<a href="mailto:tobias@grosser.es">tobias@grosser.es</a>> wrote:<br>
<br>
> Steffen, I believe the idea of your patch is great. Unfortunately it has from my point two issues:<br>
><br>
> 1) You rely on features of very recent vim versions<br>
<br>
</div>I've addressed this in in the revised script that I've just sent in a separate mail.<br>
<div class="im"><br>
<br>
> As this is not a complicated plugin, there seems no reason to drop support for older vim versions.<br>
><br>
> 2) You require python in the .vimrc file<br>
><br>
> I would prefer to not require python in the .vimrc, but have the plugin report an error when it is called without python support.<br>
<br>
</div>Python has also been required by the previous version of the script. So my proposed changes don't make the situation worse.<br>
<br>
I agree that a full plugin would be ideal. I think that it would ideally be hosted in a separate git repo on Github, so that Pathogen or Vundle can be used to install it. However, I don't plan to create such a plugin anytime soon.<br>
<span class="HOEnZb"><font color="#888888"><br>
Steffen<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
</div></div></blockquote></div><br></div>