<div dir="ltr">On Thu, Aug 29, 2013 at 3:56 PM, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com" target="_blank">eli.friedman@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="im">On Thu, Aug 22, 2013 at 11:15 PM, Peter N Lewis <span dir="ltr"><<a href="mailto:peter@stairways.com.au" target="_blank">peter@stairways.com.au</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I'm currently waiting for approval or feedback on adding the following GNU flags in the -Wgnu group:<br>


<br>
gnu-binary-literal<br></blockquote></div></div></div></div></blockquote><div><br></div><div>This is also a C++1y language extension; we should put it under -Wc++1y-extensions in C++ mode, and under -Wgnu-binary-literal in C mode.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

gnu-imaginary-constant<br>
gnu-line-zero-directive<br></blockquote></div></div></div></div></blockquote><div><br></div><div>Maybe -Wgnu-#line-0? (We have precedent for # in a warning name: -W#warnings, -W#pragma-messages)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

gnu-token-pasting-comma<br>
gnu-zero-variadic-macro-arguments<br></blockquote></div></div></div></div></blockquote><div><br></div><div>These two are the definition and use side of the same feature, so should probably live under the same flag.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

And then the next batch of names (which I've done already) is:<br>
<br>
gnu-anonymous-struct<br>
gnu-compound-literal-initializer<br>
gnu-empty-struct<br>
gnu-flexible-array-initializer<br>
gnu-flexible-array-union-member<br>
gnu-folding-initializer-constant<br>
gnu-folding-integer-constant<br>
gnu-only-flexible-array-member<br>
gnu-redeclared-class-member<br>
gnu-redeclaration-enum<br>
gnu-struct-without-named-member<br>
gnu-union-cast<br>
gnu-variable-sized-type-not-at-end<br></blockquote><div><br></div></div><div>gnu-empty-struct, gnu-struct-without-named-member, and gnu-only-flexible-array-member are all variants of the same extension (allowing structs without a named member); it probably makes sense to put them all under gnu-empty-struct.</div>

<div><br></div><div>gnu-folding-initializer-constant and gnu-folding-integer-constant are also variants of the same extension (along with ext_vla_folded_to_constant)<br></div><div><br></div><div>gnu-redeclared-class-member probably shouldn't have "gnu" in the name; it's not really an intentional extension.<br>

</div><div><br></div><div>(This isn't a formal review; please continue to submit patches as you have been doing.)</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-Eli</div></font></span></div></div>
</div>
<br>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br></blockquote></div><br></div></div>