<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Looks good. Please, commit. <div><br></div><div>Thanks for fixing!<div>Anna.<br><div><div>On Jun 21, 2013, at 4:45 AM, Andrey Vagin <<a href="mailto:avagin@openvz.org">avagin@openvz.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">CC and CCX must be set not only for the IgnoreErrors case.<br><br>This patch fixes a case when CC is defined in Makefile, because<br>a value form the environment variable has smaller priority than makefile<br>definition.<br><br>"""<br>The priority of assignments is from least binding to most binding; the<br>* precedence of assignments is:<br>* internal definitions<br>* environment<br>* makefile(s)<br>* command line<br>"""<br><br>This bug was found by Roman Kagan <<a href="mailto:rkagan@parallels.com">rkagan@parallels.com</a>>.<br><br>Signed-off-by: Andrey Vagin <<a href="mailto:avagin@openvz.org">avagin@openvz.org</a>><br>---<br>tools/scan-build/scan-build | 8 ++++----<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br>diff --git a/tools/scan-build/scan-build b/tools/scan-build/scan-build<br>index 22d5289..cb79903 100755<br>--- a/tools/scan-build/scan-build<br>+++ b/tools/scan-build/scan-build<br>@@ -1017,10 +1017,10 @@ sub RunBuildCommand {<br> shift @$Args;<br> unshift @$Args, $CXXAnalyzer;<br> }<br>- elsif ($IgnoreErrors) {<br>- if ($Cmd eq "make" or $Cmd eq "gmake") {<br>- AddIfNotPresent($Args, "CC=$CCAnalyzer");<br>- AddIfNotPresent($Args, "CXX=$CXXAnalyzer");<br>+ elsif ($Cmd eq "make" or $Cmd eq "gmake") {<br>+ AddIfNotPresent($Args, "CC=$CCAnalyzer");<br>+ AddIfNotPresent($Args, "CXX=$CXXAnalyzer");<br>+ if ($IgnoreErrors) {<br> AddIfNotPresent($Args,"-k");<br> AddIfNotPresent($Args,"-i");<br> }<br>--<span class="Apple-converted-space"> </span><br>1.8.2.1<br><br>_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a></div></blockquote></div><br></div></div></body></html>