<div dir="ltr">On Wed, Jun 19, 2013 at 12:38 PM, Thompson, John <span dir="ltr"><<a href="mailto:John_Thompson@playstation.sony.com" target="_blank">John_Thompson@playstation.sony.com</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">





<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="color:#1f497d">Right off, a message elsewhere pointed me to an improvement:<u></u><u></u></span></p><div class="im">
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">std::string PreprocessorCallbacks::getSourceSnippet(SourceRange sourceRange) {<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">  SourceLocation bLoc(sourceRange.getBegin());<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">  SourceLocation eLoc(sourceRange.getEnd());<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"><u></u> <u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:green">// Decompose the locations into FID/Offset pairs.</span><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">  std::pair<FileID,
<span style="color:blue">unsigned</span>> bLocInfo = PP.getSourceManager().getDecomposedLoc(bLoc);<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">  std::pair<FileID,
<span style="color:blue">unsigned</span>> eLocInfo = PP.getSourceManager().getDecomposedLoc(eLoc);<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">  FileID FID = bLocInfo.first;<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> <span style="color:blue">unsigned</span> bFileOffset = bLocInfo.second;<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:blue">unsigned</span> eFileOffset = eLocInfo.second;<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:blue">unsigned</span> length = eFileOffset - bFileOffset;<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"><u></u> <u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:green">// Get information about the buffer it points into.</span><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:blue">bool</span> Invalid = <span style="color:blue">false</span>;<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:blue">const</span> <span style="color:blue">char</span> *BufStart = PP.getSourceManager().getBufferData(FID, &Invalid).data();<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:blue">if</span> (Invalid)<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">   
<span style="color:blue">return</span> std::string();<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"><u></u> <u></u></span></p>
</div><p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"> 
<span style="color:blue">return</span> StringRef(BufStart + bFileOffset, length).trim().str();<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas">}<u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:9.5pt;font-family:Consolas"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">Anything better?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> </span></p></div></div></blockquote><div><br></div><div>You could use SourceManager::getCharacterData().</div><div><br></div><div>-Eli</div></div><br></div></div>