<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM.<div><br><div><div>On May 13, 2013, at 5:46 AM, "Langmuir, Ben" <<a href="mailto:ben.langmuir@intel.com">ben.langmuir@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple" style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="WordSection1" style="page: WordSection1;"><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">I was able to reproduce this by setting -triple=powerpc64-unknown-linux-gnu. I’ve attached a patch that should fix the problem – could someone give this a quick review?<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);"> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">Thanks,<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);"> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">Ben<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);"> </span></div><div style="border-style: none none none solid; border-left-color: blue; border-left-width: 1.5pt; padding: 0in 0in 0in 4pt;"><div><div style="border-style: solid none none; border-top-color: rgb(181, 196, 223); border-top-width: 1pt; padding: 3pt 0in 0in;"><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><b><span style="font-size: 10pt; font-family: Tahoma, sans-serif;">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif;"><span class="Apple-converted-space"> </span><a href="mailto:cfe-dev-bounces@cs.uiuc.edu" style="color: purple; text-decoration: underline;">cfe-dev-bounces@cs.uiuc.edu</a><span class="Apple-converted-space"> </span>[<a href="mailto:cfe-dev-bounces@cs.uiuc.edu" style="color: purple; text-decoration: underline;">mailto:cfe-dev-bounces@cs.uiuc.edu</a>]<span class="Apple-converted-space"> </span><b>On Behalf Of<span class="Apple-converted-space"> </span></b>Ismail Dönmez<br><b>Sent:</b><span class="Apple-converted-space"> </span>Sunday, May 12, 2013 5:05 AM<br><b>To:</b><span class="Apple-converted-space"> </span><a href="mailto:cfe-dev@cs.uiuc.edu" style="color: purple; text-decoration: underline;">cfe-dev@cs.uiuc.edu</a><br><b>Subject:</b><span class="Apple-converted-space"> </span>[cfe-dev] CodeGenCXX/captured-statements.cpp test fails on Linux PowerPC 64<o:p></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p> </o:p></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;">Hi,<o:p></o:p></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p> </o:p></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;">I got the following on openSUSE 13.1 PPC64:<o:p></o:p></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><br>[58620s] ******************** TEST 'Clang :: CodeGenCXX/captured-statements.cpp' FAILED ********************<br>[58620s] Script:<br>[58620s] --<br>[58620s] /home/abuild/rpmbuild/BUILD/llvm/stage2/Release/bin/clang -cc1 -internal-isystem /home/abuild/rpmbuild/BUILD/llvm/stage2/Release/bin/../lib64/clang/3.4/include -std=c++11 -emit-llvm /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -o /home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp<br>[58620s] FileCheck /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -input-file=/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp -check-prefix=CHECK-1<br>[58620s] FileCheck /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -input-file=/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp -check-prefix=CHECK-2<br>[58620s] FileCheck /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -input-file=/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp -check-prefix=CHECK-3<br>[58620s] FileCheck /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -input-file=/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp -check-prefix=CHECK-4<br>[58620s] FileCheck /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -input-file=/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp -check-prefix=CHECK-5<br>[58620s] FileCheck /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp -input-file=/home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp -check-prefix=CHECK-6<br>[58620s] --<br>[58620s] Exit Code: 1<br>[58620s] Command Output (stderr):<br>[58620s] --<br>[58620s] /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/CodeGenCXX/captured-statements.cpp:58:14: error: expected string not found in input<br>[58620s] // CHECK-2: call i32 @[[Lambda:["$\w]+]]<br>[58620s] ^<br>[58620s] /home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp:54:23: note: scanning from here<br>[58620s] define void @_Z5test2i(i32 signext %x) #0 {<br>[58620s] ^<br>[58620s] /home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/CodeGenCXX/Output/captured-statements.cpp.tmp:55:11: note: possible intended match here<br>[58620s] %1 = alloca i32, align 4<br>[58620s] ^<br>[58620s] --<br>[58620s]<o:p></o:p></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p> </o:p></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;">Any ideas?<o:p></o:p></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p> </o:p></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;">Thanks!<o:p></o:p></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p> </o:p></div></div></div></div></div><span><fix-capturedstmt-codegen-powerpc.patch></span>_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu" style="color: purple; text-decoration: underline;">cfe-dev@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" style="color: purple; text-decoration: underline;">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br></div></blockquote></div><br></div></body></html>