<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks Daniel! It works now.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>-Jyotsna<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>--<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> daniel.dunbar@gmail.com [mailto:daniel.dunbar@gmail.com] <b>On Behalf Of </b>Daniel Dunbar<br><b>Sent:</b> Thursday, April 18, 2013 12:55 PM<br><b>To:</b> Richard Smith<br><b>Cc:</b> Jyotsna Verma; cfe-dev@cs.uiuc.edu Developers<br><b>Subject:</b> Re: c11.c/cxx11.cpp tests are failing for Hexagon<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Hi Jyotsna,<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>You are right this is poor behavior in the tests (which shouldn't ever depend on the system headers).<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>I believe the c11.c test should be fixed here:<o:p></o:p></p></div><div><p class=MsoNormal> <a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=179723" target="_blank">http://llvm.org/viewvc/llvm-project?view=revision&revision=179723</a><o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Is that not the case?<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal> - Daniel<o:p></o:p></p></div></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Wed, Apr 17, 2013 at 12:19 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>> wrote:<o:p></o:p></p><div><div><p class=MsoNormal>On Wed, Apr 17, 2013 at 10:39 AM, Jyotsna Verma <<a href="mailto:jverma@codeaurora.org" target="_blank">jverma@codeaurora.org</a>> wrote:<o:p></o:p></p></div><div><div><div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>Hi Daniel/Richard,<br><br>I'm seeing c11.c and cxx11.cpp tests failing on Hexagon with these two<br>changes - r179427 and r179419.<br><br>After your changes, we include stdint.h file (from lib/Headers) in both<br>these tests. However, if __STDC_HOSTED__ macro is defined,<br>lib/Headers/stdint.h includes system stdint.h file which includes features.h<br>-> gnu/stubs-32.h. Since, we don't have stubs-32.h header file available for<br>Hexagon, it causes the tests to fail.<br><br>Please help me understand why the tests were modified to include stdint.h<br>file and how to fix them for Hexagon.<o:p></o:p></p></blockquote><div><p class=MsoNormal><o:p> </o:p></p></div></div><div><p class=MsoNormal>These tests are testing the behavior of our <stdint.h> implementation. It would certainly make sense to make them avoid including a system-provided <stdint.h>. That will probably require somewhat different fixes for each test:<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>I think (perhaps Daniel can confirm) that the c11.c test just wants to test the contents of our own <stdint.h>, so modifying the test's RUN: line so that the system-provided <stdint.h> is not on the search path would suffice.<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>For the cxx11.c test, what we're checking is that our builtin <stdint.h> correctly works around <a href="http://sourceware.org/PR15366" target="_blank">http://sourceware.org/PR15366</a> -- though a better (non-system-dependent) test here would be to craft a "system header" <stdint.h> with the C99-specified behavior and put that in the system headers include path for the test.<o:p></o:p></p></div></div></div></div></div><p class=MsoNormal><o:p> </o:p></p></div></div></div></body></html>