<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Ahy did you remove test/Parser/prefix-attributes.m test? <div>Other than that lgtm.</div><div>- Fariborz</div><div><br><div><div>On Apr 3, 2013, at 8:44 AM, Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div dir="ltr">On Wed, Apr 3, 2013 at 1:00 AM, John McCall<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div class="HOEnZb"><div class="h5">On Apr 2, 2013, at 7:51 PM, Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:<br>> it's<br>><br>> class __attribute__((visibility("hidden"))) A {};<br>><br>> but<br>><br>> __attribute__((visibility("hidden"))) @interface I @end<br>><br>> In the first case, clang emits a nice fixit if the attribute is written before the class keyword, while putting the attribute after @interface makes clang print an ugly diagnostic.<br>><br>> Instead of just making that print a nice fixit too, what do you think about allowing attributes for @interfaces after the @interface keyword too?<br><br></div></div>I see no reason to introduce confusion about where to put attributes in an @interface. It's not like after the @interface is actually a good place to put attributes.<br></blockquote><div><br></div><div>Ok. The attached patch gives attributes after an objc directive a nicer diagnostic then. Is this ok?</div><div><br></div><div>Nico</div><div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><span class="HOEnZb"><font color="#888888"><br>John.<br></font></span></blockquote></div><br></div></div><span><clang-objc-attrs.patch></span>_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a></div></blockquote></div><br></div></body></html>