<div dir="ltr">Sure. I will sync to latest and re-create the patches against a more recent revision. <div><br></div><div style>PS. This was the email from Feb 13. <a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130211/074110.html">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130211/074110.html</a></div>
<div style><br></div><div style>Phil</div><div class="gmail_extra">--<br><div>Philip Dunstan<br><a href="mailto:phil@philipdunstan.com" target="_blank">phil@philipdunstan.com</a><br><a href="http://www.philipdunstan.com" target="_blank">www.philipdunstan.com</a></div>
<br><br><div class="gmail_quote">On Wed, Mar 27, 2013 at 12:47 PM, Vane, Edwin <span dir="ltr"><<a href="mailto:edwin.vane@intel.com" target="_blank">edwin.vane@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I don’t see any emails from you to cfe-commits on Feb 13. Last email I see is from Feb 4 when the patches were still under review and you were working on some
problems. I don’t remember ever seeing a reviewer’s approval. Could you send the patches again?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Philip Dunstan [mailto:<a href="mailto:phil@philipdunstan.com" target="_blank">phil@philipdunstan.com</a>]
<br>
<b>Sent:</b> Tuesday, March 26, 2013 1:51 AM<br>
<b>To:</b> Vane, Edwin<br>
<b>Cc:</b> Dmitri Gribenko; <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a>; Matthieu Monrocq</span></p><div><div class="h5"><br>
<b>Subject:</b> Re: [cfe-dev] Adding -add-override functionality to cpp11-migrate tool<u></u><u></u></div></div><p></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Sorry, I haven't had a chance to chase this up lately. I've been changing jobs and then on holiday for a couple of weeks with limited internet access.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I posted the latest set of patches to cfe-commits on February 13 but I don't think they were ever committed. Do I need to do something in particular to have the patches applied?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">thanks.<u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal">Phil<br>
--<br>
Philip Dunstan<br>
<a href="mailto:phil@philipdunstan.com" target="_blank">phil@philipdunstan.com</a><br>
<a href="http://www.philipdunstan.com" target="_blank">www.philipdunstan.com</a><u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Mar 18, 2013 at 11:50 AM, Vane, Edwin <<a href="mailto:edwin.vane@intel.com" target="_blank">edwin.vane@intel.com</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Any news on this transform?</span><u></u><u></u></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Philip Dunstan [mailto:<a href="mailto:phil@philipdunstan.com" target="_blank">phil@philipdunstan.com</a>]
<br>
<b>Sent:</b> Tuesday, February 05, 2013 2:02 PM<br>
<b>To:</b> Dmitri Gribenko<br>
<b>Cc:</b> <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a>; Matthieu Monrocq; Vane, Edwin<br>
<b>Subject:</b> Re: [cfe-dev] Adding -add-override functionality to cpp11-migrate tool</span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I've attached patches that include this new test:<u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal">Phil<br>
--<br>
Philip Dunstan<br>
<a href="mailto:phil@philipdunstan.com" target="_blank">phil@philipdunstan.com</a><br>
<a href="http://www.philipdunstan.com" target="_blank">www.philipdunstan.com</a><u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Feb 5, 2013 at 7:23 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>> wrote:<u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Feb 5, 2013 at 7:44 PM, Philip Dunstan <<a href="mailto:phil@philipdunstan.com" target="_blank">phil@philipdunstan.com</a>> wrote:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">> I haven't modified yet how the insertion point for the override keyword is<br>
> calculated. Dmitri suggested FunctionTypeLoc::getRParenLoc() but I don't<br>
> think that this will work if there is a trailing const keyword or deferred<br>
> return type.<u></u><u></u></p>
</div>
<p class="MsoNormal">Could you please add a test with a trailing return type anyway?<br>
<br>
class A {<br>
public:<br>
virtual int h();<br>
};<br>
<br>
class B {<br>
public:<br>
auto h() -> int;<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">};<br>
<br>
Dmitri<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div>
</div>
</blockquote></div><br></div></div>