<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr">On Mon, Dec 3, 2012 at 2:01 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br>
<div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 12/03/2012 01:24 PM, Chandler Carruth wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
On Mon, Dec 3, 2012 at 4:04 AM, Tobias Grosser <<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a><br></div><div class="im">
<mailto:<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>>> wrote:<br>
<br>
On 12/03/2012 08:05 AM, Manuel Klimek wrote:<br>
<br>
On Fri, Nov 30, 2012 at 9:26 AM, ramneek<br>
<<a href="mailto:onewastedlife@gmail.com" target="_blank">onewastedlife@gmail.com</a> <mailto:<a href="mailto:onewastedlife@gmail.com" target="_blank">onewastedlife@gmail.<u></u>com</a>><br></div>
<mailto:<a href="mailto:onewastedlife@gmail." target="_blank">onewastedlife@gmail.</a>__<u></u>com<div class="im"><br>
<mailto:<a href="mailto:onewastedlife@gmail.com" target="_blank">onewastedlife@gmail.<u></u>com</a>>>> wrote:<br>
<br>
Would it be ok if i worked on a patch to move things to a<br>
namespace<br>
for the first cut while we decide how we can allow plugins.<br>
Also we should be ignoring the namespaces that we are not<br>
using so<br>
it allows applications to add their custom data to while<br>
preserving<br>
the acceptable file format.<br>
<br>
My proposal is actually simple:<br>
<br>
This is what we have today:<br>
<br>
[<br></div>
{"directory":"/home/user/llvm/<u></u>__build",<div class="im"><br>
"command":"/usr/bin/clang++ -Irelative -DSOMEDEF='\"With spaces<br>
and quotes.\"' -c -o file.o file.cc",<br>
"file":"file.cc" },<br>
…<br>
]<br>
<br>
We can move it to (cc = compile commands):<br>
<br></div>
{"cc" :{"directory":"/home/user/__<u></u>llvm/build",<div class="im"><br>
<br>
"command":"/usr/bin/clang++ -Irelative -DSOMEDEF='\"With spaces<br>
and quotes.\"' -c -o file.o file.cc",<br>
"file":"file.cc" },<br>
…<br>
]<br>
<br>
<br>
One thing that we will have to be careful about is that we<br>
will have to patch the cmake compilation command generation<br>
facility as well..<br>
<br>
I can look into that as well or make the change such that<br>
it is backwards compatible?<br>
<br>
<br>
I'm still torn. While I see the arguments for why being strict<br>
might be<br>
a problem if we plan to change the format, I don't understand<br>
the need<br>
for the namespace / being able to have different things in a<br>
single file<br>
yet.<br>
<br>
<br>
I also have no opinion about name spaces. However, I think it would be<br>
good if we could ensure clang 3.2 just ignores unknown content.<br>
Otherwise, the costs of adding new information to that file will be<br>
a lot higher.<br>
<br>
Manuel, do you think this change would still be OK for 3.2?<br>
<br>
<br>
Folks, 3.2 is essentially shipped. This should *not* hold up that release.<br>
</div></blockquote>
<br>
Agreed. This is really not a release blocker.<br>
<br>
On the other hand, as this is a very non-critical component, getting this small change in may still be possible, and it may make our life a little simpler in the future. To my knowledge, there is another rc3 scheduled for Wednesday, so that could be the last window to get trivial changes in.<br>
<br>
Manuel, as you are the tooling stuff expert, I leave the decision to you. I did my job of raising the topic. ;-)<br></blockquote><div><br></div><div style>I agree with Chandler that trying to get this into 3.2 is not going to be worth the effort. We should rather discuss the merits of the approaches on a principled basis and make that decision going forward.</div>
<div style><br></div><div style>Cheers,</div><div style>/Manuel</div></div></div></div></div>