On Fri, Oct 26, 2012 at 6:17 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Manuel, phab bug report: This didn't thread as a reply to the original<br>
review mail in gmail.<br></blockquote><div><br></div><div>See <a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121022/066885.html">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121022/066885.html</a></div>
<div><br></div><div>It did thread correctly. Note that Daniel changed the subject, and thus GMail cannot thread it correctly any more - pipermail's threading it shows that in theory the threading seems to be set correctly. To the best of my knowledge this is non-conforming behavior on GMail's side. (I might also be able to implement a "never change subject" switch in phab, if that's what we're after)</div>
<div><br></div><div>Cheers,</div><div>/Manuel</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div><div class="h5"><br>
On Fri, Oct 26, 2012 at 5:13 AM, Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> wrote:<br>
> Hi klimek,<br>
><br>
> <a href="http://llvm-reviews.chandlerc.com/D83" target="_blank">http://llvm-reviews.chandlerc.com/D83</a><br>
><br>
> CHANGE SINCE LAST DIFF<br>
>   <a href="http://llvm-reviews.chandlerc.com/D83?vs=211&id=212#toc" target="_blank">http://llvm-reviews.chandlerc.com/D83?vs=211&id=212#toc</a><br>
><br>
> Files:<br>
>   include/clang/ASTMatchers/ASTMatchers.h<br>
>   include/clang/ASTMatchers/ASTMatchersInternal.h<br>
>   include/clang/ASTMatchers/ASTTypeTraits.h<br>
>   lib/ASTMatchers/ASTMatchFinder.cpp<br>
>   unittests/ASTMatchers/ASTMatchersTest.cpp<br>
><br>
</div></div>> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
</blockquote></div><br></div>