<div style="font-family: arial, helvetica, sans-serif"><font size="2">Changed and submitted as r159252.<br><br><div class="gmail_quote">On Wed, Jun 27, 2012 at 3:03 AM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The __has_feature looks fine, but shouldn't you at least put an example in the test case?<br>
<br>
+class HasFeatureTest {<br>
+#if __has_feature(attribute_unused_on_fields)<br>
+ int unused_; // expected-warning{{private field 'unused_' is not used}}<br>
+ int unused2_ __attribute__((unused)); // no-warning<br>
+#endif<br>
+};<br>
+<br>
<br>
I know this is already covered by other tests, but it seems weird to test against a feature and then not use it.<br>
<span class="HOEnZb"><font color="#888888"><br>
Jordan<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Jun 26, 2012, at 3:06 PM, Daniel Jasper wrote:<br>
<br>
> Can someone please review this patch?<br>
><br>
> Thank you!<br>
> Daniel<br>
<br>
</div></div></blockquote></div><br></font></div>