<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 16, 2012, at 6:54 AM, Daniel Powell wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi,<br><br>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">HandlePragma should take a SourceRange that covers the '#pragma' or '_Pragma', so that this information is available to the pragma handlers. It should be a fairly simple change to Clang; would you like to contribute a patch for it?<br>
</blockquote><div><br>Happy to. Just to check, you are suggesting I modify the current HandlePragma method to have the following prototype?<br>virtual void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer, Token &FirstToken, SourceLocation IntroducerLoc) = 0;</div></div></blockquote><div><br></div>With the SourceRange change from your follow-up e-mail, yes.</div><div><br><blockquote type="cite">With the three types of pragma supported (#pragma, _Pragma and __Pragma) their locations only appear available when the preprocessor first discovers the token (HandleDirective, Handle_Pragma and HandleMicrosoft__pragma respectively), and is lost by the time HandlePragmaDirective is called so it's probably best to pass the location from those places to HandlePragmaDirective and onwards.<br>
<br>_Pragma and __Pragma are easy, they each have PragmaLoc pointing to the keyword. However, by the time #pragma is fully discovered it only has a location pointing to "pragma" not "#pragma". I could use the getLocWithOffset(-1) method, or catch it at the start of the HandleDirective method, which do you think is best?<br></blockquote><div><br></div>Please catch it at the start of HandleDirective and pass it down.</div><div><br><blockquote type="cite">I'll have to update the existing PragmaHandlers too.<br></blockquote><div><br></div>Yes, please!</div><div><br><blockquote type="cite">Does all this sound sane? First time someone's asked me to contribute something specific back to open source. :-D<br></blockquote></div><div><br></div><div>Yes, this sounds perfectly reasonable. Thanks for looking into it!</div><br><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br></div></body></html>