<html><head></head><body bgcolor="#FFFFFF"><div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">On Dec 19, 2011, at 8:35 PM, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:</span><br></div><div><br></div><div></div><blockquote type="cite"><div><div><div>On Dec 19, 2011, at 5:40 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">On Dec 10, 2011, at 5:20 PM, David Blaikie wrote:<br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Thanks Chris, committed as r145578. I don't suppose you'll mind some<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">similar commits as I encounter them?<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Yep, please feel free.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">While you said this - given that I've now gone & fixed /every/<br></blockquote><blockquote type="cite">violation of -Wweak-vtables across LLVM & Clang (apart from some llvm<br></blockquote><blockquote type="cite">target tblgen problems - not sure how practical they are to fix. And<br></blockquote><blockquote type="cite">gtest also fires this warning) I thought I should probably get at<br></blockquote><blockquote type="cite">least a '*nod*' before I check this in.<br></blockquote><br>Looks fine to me, please do.<br></span></blockquote></div><br><div>Chris,</div><div><br></div><div>I really hate this change. Is this really the only way to solve this problem?</div></div></blockquote><div><br></div><div>I am skeptical too. David just added 17 translation units with the purpose of speeding up the build.</div><div><br></div><div>Did it work? Numbers, please.</div><div><br></div>/jakob</body></html>