<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Dec 19, 2011, at 5:40 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">On Dec 10, 2011, at 5:20 PM, David Blaikie wrote:<br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Thanks Chris, committed as r145578. I don't suppose you'll mind some<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">similar commits as I encounter them?<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Yep, please feel free.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">While you said this - given that I've now gone & fixed /every/<br></blockquote><blockquote type="cite">violation of -Wweak-vtables across LLVM & Clang (apart from some llvm<br></blockquote><blockquote type="cite">target tblgen problems - not sure how practical they are to fix. And<br></blockquote><blockquote type="cite">gtest also fires this warning) I thought I should probably get at<br></blockquote><blockquote type="cite">least a '*nod*' before I check this in.<br></blockquote><br>Looks fine to me, please do.<br></span></blockquote></div><br><div>Chris,</div><div><br></div><div>I really hate this change. Is this really the only way to solve this problem?</div><div><br></div><div>Ted</div></body></html>