<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 17, 2011, at 6:14 AM, Nikola Smiljanic wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Tue, Aug 16, 2011 at 8:26 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">Like this? (patch attached, no test cases yet) - I don't know if I</div>
should be doing something better than SetDelayedDiagnostic now that we<br>
don't really need to delay it at all.<br><br></blockquote><div><br></div><div> Your patch does the trick (the question about SetDelayedDiagnostic still remains). Here are the test cases:</div></div></blockquote><div><br></div><div>SetDelayedDiagnostic is a reasonable way to deal with this.</div><br><blockquote type="cite"><div class="gmail_quote"><div>The first one checks if both error and note are emitted before the fatal error, and that nothing is emitted afterwards</div>
<div>The second one checks that multiple notes are emitted correctly before the fatal error, and that nothing is emitted afterwards</div><div><br></div><div>Should I include one more that checks that no fatal error is emitted when the limit is 1 and there is only one error?</div>
<div><br></div><div>There is also a piece of code that allows notes to be attached to the fatal error. I wanted to write a test for this but I'm not sure that this is used anywhere (the only fatal error I can see is fatal_too_many_errors and there are no notes being attached)?</div>
</div>
</blockquote><br></div><div>These tests look great to me; I've committed them, along with David's patch, as r137851.</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><br></body></html>