<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 10, 2011, at 3:32 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div>I love this. It's been unwritten policy for the warnings we're adding, and I think it'd be good to do it generally.</div><div><br></div><div>I'll particularly like that we can test and ensure that new warnings are always given a flag. =] Hopefully we can help move some of the warnings under flags that aren't yet.</div><div><br></div></span><br class="Apple-interchange-newline"></blockquote></div><br><div>Okay, the consensus is we should do this. We can haggle out the naming of -W flags we go forward.</div><div><br></div><div>I've added the diagtool test that enforces that all new warnings require a flag:</div><div><br></div><div><a href="http://llvm.org/viewvc/llvm-project?view=rev&revision=137369">http://llvm.org/viewvc/llvm-project?view=rev&revision=137369</a></div></body></html>