<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 5, 2011, at 9:38 PM, Eli Bendersky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br><blockquote type="cite"><div dir="ltr"><div class="gmail_quote"><div>Hi Doug, thanks for the review. I'm attaching an updated patch with fixes for all your comments. <br></div></div></div></blockquote>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div style="word-wrap:break-word"><div><div class="h5"><div><br></div></div></div><div>Committed as r134460, thanks!</div>
<div><br></div><div>I forgot to mention it before, but please send future patches to the cfe-commits mailing list.</div><div><br></div><div><span style="white-space:pre-wrap"> </span>- Doug</div></div>
</blockquote></div><br>Hi Doug,<br>Another related question: I would like to expose the various statement kinds in libclang, to allow client code to reason based on the type of statement it encounters. Currently none of the statement kinds (except labels) is exposed. Would it be acceptable to submit a fix for this, or is the statement kind enumeration kept intentionally minimal?<br></div></blockquote><br></div><div>It's fine to submit a fix for this, as long as the exposed cursor kinds map to language constructs and not Clang internal implementation details. </div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><br></body></html>