<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Oct 22, 2010, at 1:13 AM, Zhongxing Xu wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><blockquote class="gmail_quote" style="margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex; position: static; z-index: auto; ">Basically this assumption doesn't match how we treat binary operators in the CFG. We should probably fix having the LHS always precessed first. Any objections?</blockquote><div><br>I agree. So the fix would be in CFGBlock *CFGBuilder::VisitChildren(Stmt* Terminator), visit the children in reverse order.<br></div></span><br class="Apple-interchange-newline"></blockquote></div><br><div>My caution here is that we don't want to make CFG construction time too expensive, as it will directly impact compile-time. I'm not saying we shouldn't do this, only that we are mindful of possible performance implications.</div><div><br></div><div>In this case, I would just start with handling BinaryOperator more correctly.</div></body></html>