<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 21, 2010, at 11:43 AM, Douglas Gregor wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 21, 2010, at 11:36 AM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 21, 2010, at 11:17 AM, Tom Care wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Chris,<div><br></div><div>Works great except now I'm getting off by 1 problems at the end of the string:</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Monaco; ">/tmp/fixit.c:41:12: warning: flag '0' is ignored when flag '-' is present</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Monaco; "> printf("%0-f", 1.23);</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Monaco; "> ~^~</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Monaco; "><br></div><div><div>Should my SourceLocation for the end byte be pointing to the 'f' or the '"'? It's currently pointing to the 'f'.</div></div></div></div></blockquote><div><br></div><div>You tell me. Right now, the ranges are set up for half open ranges [start, end). If you want fully inclusive ranges [start, end] I can make that work, just let me know what feels most natural from a client standpoint.</div></div></div></blockquote><br></div><div>Please keep it as half-open!</div></div></blockquote><br></div><div>Ok. Tom, please add one! :)</div><div><br></div><div>-Chris</div><div><br></div><br></body></html>