<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jan 14, 2010, at 11:05 AM, Andrew Sutton wrote:</div><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap: break-word;"><div>Looking at the PCH patch, your general approach seems good, but I'm not sure why you've introduced PCHReader/Writer::VisitFunctionBase rather than just calling VisitFunctionDecl from all the subclass methods. Is there some reason I'm not recalling that the param references have to come last in the record?</div>
</div></blockquote><div><br>I wasn't sure if ordering of records mattered or not. I was trying to preserve the same basic ordering of records for Method and kin, and not set the Code member twice. In the end, it probably won't matter too much.<br></div></div></blockquote><div><br></div><div>If you mean ordering of data within a record, it's better to have more redundancy between record kinds, because we do support compact representations. That probably won't matter much here. Worry about having clean code first; we don't really understand where the significant overheads are in PCH processing, but they're almost certainly not in redundantly setting the Code member. :)</div><div><br></div></div>John.</body></html>