<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 24, 2009, at 7:42 AM, John Thompson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Here's an updated version of my attempt to fix a problem with attributes coming after a declaration, but before other stuff, plus the beginnings of C++ test for it. Sorry, I don't know attributes well, so I didn't try to make it more exhaustive.</div>
<div> </div>
<div>Could someone check this out for me, or do a more correct fix?</div></blockquote><div><br></div><div>The patch looks fine, thanks! Any chance you're also interested in tackling the related PR here?</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> <a href="http://llvm.org/bugs/show_bug.cgi?id=5605">http://llvm.org/bugs/show_bug.cgi?id=5605</a></span></div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug the Insatiable</div><br><blockquote type="cite">
<div>Thanks.</div>
<div> </div>
<div>-John<br></div>
<div class="gmail_quote">On Thu, Nov 19, 2009 at 8:23 PM, John Thompson <span dir="ltr"><<a href="mailto:john.thompson.jtsoftware@gmail.com">john.thompson.jtsoftware@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Oh, I'm sorry, I forgot to hit save after editing the patch. Here it is again with just the relevant changes. I also beefed up the C test a little, but it just occured to me that there probably should be an additional test file in C++, nonetheless here's a start.
<div>
<div></div>
<div class="h5"><br><br>
<div class="gmail_quote">On Thu, Nov 19, 2009 at 8:04 PM, Sean Hunt <span dir="ltr"><<a href="mailto:rideau3@gmail.com" target="_blank">rideau3@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div>
<div></div>
<div>John Thompson wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">I have a couple of cases where I'm getting an error from Clang from code that compiles with gcc.<br> The code reduces to something like (members in a class declaration):<br>
virtual void Log(const char*, ...) __attribute__ (( __format__(__printf__,1,2) )) = 0;<br>virtual void PushContextMessage(const char* , ...) __attribute__ (( __format__(__printf__,1,2) )) {};<br>Both get "expected ';' at end of declaration list" errors.<br>
The enclosed patch takes a stab at fixing it with some copy/paste programming, assuming it needs fixing, but you might have a better fix or feedback.<br> -John<br></blockquote><br></div></div>There's a lot of code in that patch that isn't directly related to the problem - could you please post a patch of just the specific changes you would make to address this issue?<br>
<font color="#888888"><br>Sean<br></font></blockquote></div><br><br clear="all"><br></div></div>
<div>
<div></div>
<div class="h5">-- <br>John Thompson<br><a href="mailto:John.Thompson.JTSoftware@gmail.com" target="_blank">John.Thompson.JTSoftware@gmail.com</a><br><br></div></div></blockquote></div><br><br clear="all"><br>-- <br>John Thompson<br>
<a href="mailto:John.Thompson.JTSoftware@gmail.com">John.Thompson.JTSoftware@gmail.com</a><br><br>
<span><attr_pos1.patch></span><span><cxx-attributes.cpp></span>_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev<br></blockquote></div><br></body></html>