<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.6000.16939" name=GENERATOR></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=390403018-22112009><FONT face=Arial
size=2>Alright. Committed as 89609, then.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=390403018-22112009><FONT face=Arial
size=2>-Ken</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> cfe-dev-bounces@cs.uiuc.edu
[mailto:cfe-dev-bounces@cs.uiuc.edu] <B>On Behalf Of </B>John
Thompson<BR><B>Sent:</B> Thursday, November 19, 2009 2:46 PM<BR><B>To:</B>
cfe-dev@cs.uiuc.edu<BR><B>Subject:</B> Re: [cfe-dev] Reinstating stdint.h in
test/CodeGen/const-init.c<BR></FONT><BR></DIV>
<DIV></DIV>It works on Windows.<BR><BR>
<DIV class=gmail_quote>On Thu, Nov 19, 2009 at 11:26 AM, Ken Dyck <SPAN
dir=ltr><<A
href="mailto:Ken.Dyck@onsemi.com">Ken.Dyck@onsemi.com</A>></SPAN>
wrote:<BR>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">In
October (in r84160) the #include<stdint.h>
in<BR>test/CodeGen/const-init.c was replaced with an explicit definition
of<BR>intptr_t. From what I gather, this was done to get the test to
succeed<BR>on Windows, where a host stdint.h is not implemented and clang,
in<BR>hosted mode, blindly attempts to include one
anyways.<BR><BR>Explicitly defining intptr_t in the file has the problem of
relying on<BR>the built-in macro, __INTPTR_TYPE__, which I would consider
an<BR>implementation detail of stdint.h, one that I'd like to remove (but
I'll<BR>save that discussion for another thread).<BR><BR>I'd like to propose
an alternate fix. See the attached patch. It runs<BR>the test in
freestanding mode, forcing the inclusion of clang's stdint.h<BR>instead
looking for a hosted one. And, more importantly, it doesn't rely<BR>on any
built-in
macros.<BR><BR>Thoughts?<BR><BR>-Ken<BR><BR>_____________________________<BR>Ken
Dyck<BR>Senior Member of Technical Staff<BR>Software Tools
Development<BR>Medical Division<BR>ON Semiconductor<BR><FONT
color=#888888><A
href="mailto:ken.dyck@onsemi.com">ken.dyck@onsemi.com</A><BR>+1 519 884 9696
ext 2277 | office<BR>+1 519 884 0228 | fax<BR><A href="http://onsemi.com/"
target=_blank>http://onsemi.com</A><BR>_____________________________<BR></FONT><BR>_______________________________________________<BR>cfe-dev
mailing list<BR><A
href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</A><BR><A
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev"
target=_blank>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</A><BR><BR></BLOCKQUOTE></DIV><BR><BR
clear=all><BR>-- <BR>John Thompson<BR><A
href="mailto:John.Thompson.JTSoftware@gmail.com">John.Thompson.JTSoftware@gmail.com</A><BR><BR></BLOCKQUOTE></BODY></HTML>