<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Victor,<div><br></div><div>the patches look great! Thanks for fixing this :)</div><div><br></div><div>One small comment - could you move the conditional temporaries tests into a separate file? You could call it conditional-temporaries.cpp</div><div><br></div><div>Thanks,</div><div>Anders</div><div><br><div><div>17 nov 2009 kl. 23.20 skrev Victor Zverovich:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>The first patch (cond-temp-test.patch) adds 3 new test cases that check the lifetime of conditional temporaries.</div><div>The second patch (cond-temp.patch) fixes the bug making the new test cases pass.</div><div><br>
</div><div>Victor<br><br><div class="gmail_quote">2009/11/17 Victor Zverovich <span dir="ltr"><<a href="mailto:victor.zverovich@googlemail.com">victor.zverovich@googlemail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I submitted it here <a href="http://llvm.org/bugs/show_bug.cgi?id=5539" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=5539</a> so that it is not lost until I come up with a fix.<br><br><div>Victor</div><div><br><div class="gmail_quote">
2009/11/17 Anders Carlsson <span dir="ltr"><<a href="mailto:andersca@mac.com" target="_blank">andersca@mac.com</a>></span><div><div></div><div class="h5"><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
17 nov 2009 kl. 04.44 skrev Victor Zverovich:<br>
<br>
> Dear all<br>
<div>><br>
> The same applies to && and || operators. Is this intended or needs to be fixed in clang?<br>
> In the latter case and if nobody is already working on it I can try fixing it.<br>
><br>
<br>
</div>Hi Victor,<br>
<br>
this should work. Please file a bug.<br>
<br>
Anders<br>
<br>
> Best regards,<br>
> Victor<br>
><br>
> _______________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br>
</blockquote></div></div></div><br></div>
</blockquote></div><br></div>
<span><cond-temp-test.patch></span><span><cond-temp.patch></span>_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev<br></blockquote></div><br></div></body></html>